* [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c
@ 2006-02-08 3:18 Al Viro
2006-02-08 3:53 ` Jeff Garzik
2006-02-08 12:28 ` [PATCH] mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h Dale Farnsworth
0 siblings, 2 replies; 3+ messages in thread
From: Al Viro @ 2006-02-08 3:18 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, dale, jgarzik
Date: 1137630954 -0500
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/net/mv643xx_eth.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
b6298c22c5e9f698812e2520003ee178aad50c10
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 7ef4b04..c0998ef 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -32,6 +32,8 @@
*/
#include <linux/init.h>
#include <linux/dma-mapping.h>
+#include <linux/in.h>
+#include <linux/ip.h>
#include <linux/tcp.h>
#include <linux/udp.h>
#include <linux/etherdevice.h>
--
0.99.9.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c
2006-02-08 3:18 [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c Al Viro
@ 2006-02-08 3:53 ` Jeff Garzik
2006-02-08 12:28 ` [PATCH] mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2006-02-08 3:53 UTC (permalink / raw)
To: Al Viro; +Cc: torvalds, linux-kernel, dale
Al Viro wrote:
> Date: 1137630954 -0500
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
ACK
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h
2006-02-08 3:18 [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c Al Viro
2006-02-08 3:53 ` Jeff Garzik
@ 2006-02-08 12:28 ` Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Dale Farnsworth @ 2006-02-08 12:28 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel, netdev, Al Viro, Olaf Hering
From: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
---
These includes were added twice:
in commit 78a5e534758349fd3effc90ce1152b55368f52ee by Olaf Hering and
in commit b6298c22c5e9f698812e2520003ee178aad50c10 by Al Viro.
This patch reverts 78a5e534758349fd3effc90ce1152b55368f52ee.
They probably should have been included before linux/tcp.h in
the first place.
drivers/net/mv643xx_eth.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
===================================================================
--- linux-2.6-mv643xx_enet.orig/drivers/net/mv643xx_eth.c
+++ linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
@@ -37,8 +37,6 @@
#include <linux/tcp.h>
#include <linux/udp.h>
#include <linux/etherdevice.h>
-#include <linux/in.h>
-#include <linux/ip.h>
#include <linux/bitops.h>
#include <linux/delay.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-08 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-08 3:18 [PATCH 04/29] missing includes in drivers/net/mv643xx_eth.c Al Viro
2006-02-08 3:53 ` Jeff Garzik
2006-02-08 12:28 ` [PATCH] mv643xx_eth: remove repeated includes of linux/in.h and linux/ip.h Dale Farnsworth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox