* [PATCH] unify pfn_to_page take 2 [16/25] parisc funcs
@ 2006-02-08 6:15 KAMEZAWA Hiroyuki
2006-02-08 7:07 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2006-02-08 6:15 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: matthew, grundler
parisc can use generic funcs.
Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Index: test-layout-free-zone/include/asm-parisc/mmzone.h
===================================================================
--- test-layout-free-zone.orig/include/asm-parisc/mmzone.h
+++ test-layout-free-zone/include/asm-parisc/mmzone.h
@@ -25,23 +25,7 @@ extern struct node_map_data node_data[];
pg_data_t *__pgdat = NODE_DATA(nid); \
__pgdat->node_start_pfn + __pgdat->node_spanned_pages; \
})
-#define node_localnr(pfn, nid) ((pfn) - node_start_pfn(nid))
-#define pfn_to_page(pfn) \
-({ \
- unsigned long __pfn = (pfn); \
- int __node = pfn_to_nid(__pfn); \
- &NODE_DATA(__node)->node_mem_map[node_localnr(__pfn,__node)]; \
-})
-
-#define page_to_pfn(pg) \
-({ \
- struct page *__page = pg; \
- struct zone *__zone = page_zone(__page); \
- BUG_ON(__zone == NULL); \
- (unsigned long)(__page - __zone->zone_mem_map) \
- + __zone->zone_start_pfn; \
-})
/* We have these possible memory map layouts:
* Astro: 0-3.75, 67.75-68, 4-64
Index: test-layout-free-zone/include/asm-parisc/page.h
===================================================================
--- test-layout-free-zone.orig/include/asm-parisc/page.h
+++ test-layout-free-zone/include/asm-parisc/page.h
@@ -130,8 +130,6 @@ extern int npmem_ranges;
#define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET))
#ifndef CONFIG_DISCONTIGMEM
-#define pfn_to_page(pfn) (mem_map + (pfn))
-#define page_to_pfn(page) ((unsigned long)((page) - mem_map))
#define pfn_valid(pfn) ((pfn) < max_mapnr)
#endif /* CONFIG_DISCONTIGMEM */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] unify pfn_to_page take 2 [16/25] parisc funcs
2006-02-08 6:15 [PATCH] unify pfn_to_page take 2 [16/25] parisc funcs KAMEZAWA Hiroyuki
@ 2006-02-08 7:07 ` Kyle McMartin
2006-02-08 7:16 ` KAMEZAWA Hiroyuki
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2006-02-08 7:07 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: Linux Kernel Mailing List, matthew, grundler
On Wed, Feb 08, 2006 at 03:15:15PM +0900, KAMEZAWA Hiroyuki wrote:
> parisc can use generic funcs.
>
ACK... Looks fine to me. Maybe the BUG_ON(zone == NULL) in page_to_pfn might
be worth keeping?
Cheers,
Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] unify pfn_to_page take 2 [16/25] parisc funcs
2006-02-08 7:07 ` Kyle McMartin
@ 2006-02-08 7:16 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; 3+ messages in thread
From: KAMEZAWA Hiroyuki @ 2006-02-08 7:16 UTC (permalink / raw)
To: Kyle McMartin; +Cc: Linux Kernel Mailing List, matthew, grundler
Kyle McMartin wrote:
> ACK... Looks fine to me.
Thanks!
> Maybe the BUG_ON(zone == NULL) in page_to_pfn might be worth keeping?
>
placeing BUG_ON(zone == NULL) in page_zone() seems better to me.
But can it happen ??
Regards,
-- Kame
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-08 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-08 6:15 [PATCH] unify pfn_to_page take 2 [16/25] parisc funcs KAMEZAWA Hiroyuki
2006-02-08 7:07 ` Kyle McMartin
2006-02-08 7:16 ` KAMEZAWA Hiroyuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox