public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, hjlipp@web.de, greg@kroah.com,
	kkeil@suse.de, akpm@osdl.org
Subject: Re: + isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree
Date: Wed, 15 Feb 2006 02:56:22 +0100	[thread overview]
Message-ID: <43F28A46.9030105@imap.cc> (raw)
In-Reply-To: <1139758170.20703.14.camel@laptopd505.fenrus.org>

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

On 12.02.2006 16:29, Arjan van de Ven wrote:
> 
>>+struct prot_skb {
>>+	atomic_t		empty;
>>+	struct semaphore	*sem;
>>+	struct sk_buff		*skb;
>>+};
> 
> please consider using mutexes instead!

Thanks for the hint. As you may have guessed, the driver dates from
pre-mutex times. :-) However, this structure is currently unused,
anyway, so we'll just remove it and recreate it with a mutex should we
need it again.

Regards
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

      reply	other threads:[~2006-02-15  1:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200602121032.k1CAWLTg002183@shell0.pdx.osdl.net>
2006-02-12 15:29 ` + isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree Arjan van de Ven
2006-02-15  1:56   ` Tilman Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F28A46.9030105@imap.cc \
    --to=tilman@imap.cc \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=hjlipp@web.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox