Re: + isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree

Re: + isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree

[Arjan van de Ven]

On Sun, 2006-02-12 at 02:31 -0800, akpm@osdl.org wrote:
> The patch titled
> 
>      isdn4linux: Siemens Gigaset drivers - common module
> 
> has been added to the -mm tree.  Its filename is
> 
>      isdn4linux-siemens-gigaset-drivers-common-module.patch
> 
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
> 
> 
> From: Hansjoerg Lipp <hjlipp@web.de>
> 
> And: Tilman Schmidt <tilman@imap.cc>



> +struct prot_skb {
> +	atomic_t		empty;
> +	struct semaphore	*sem;
> +	struct sk_buff		*skb;
> +};
> +


please consider using mutexes instead!

Re: + isdn4linux-siemens-gigaset-drivers-common-module.patch added to -mm tree

[Tilman Schmidt]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

On 12.02.2006 16:29, Arjan van de Ven wrote:
> 
>>+struct prot_skb {
>>+	atomic_t		empty;
>>+	struct semaphore	*sem;
>>+	struct sk_buff		*skb;
>>+};
> 
> please consider using mutexes instead!

Thanks for the hint. As you may have guessed, the driver dates from
pre-mutex times. :-) However, this structure is currently unused,
anyway, so we'll just remove it and recreate it with a mutex should we
need it again.

Regards
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]