From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, christoph@lameter.com
Subject: Re: + vmscan-rename-functions.patch added to -mm tree
Date: Wed, 15 Feb 2006 14:09:56 +1100 [thread overview]
Message-ID: <43F29B84.6020009@yahoo.com.au> (raw)
In-Reply-To: <2cd57c900602141847m7af4ec7ap@mail.gmail.com>
Coywolf Qi Hunt wrote:
> 2006/2/12, akpm@osdl.org <akpm@osdl.org>:
>
>>The patch titled
>>
>> vmscan: rename functions
>>
>>has been added to the -mm tree. Its filename is
>>
>> vmscan-rename-functions.patch
>>
>>See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
>>out what to do about this
>>
>>
>>From: Andrew Morton <akpm@osdl.org>
>>
>>We have:
>>
>> try_to_free_pages
>> ->shrink_caches(struct zone **zones, ..)
>> ->shrink_zone(struct zone *, ...)
>> ->shrink_cache(struct zone *, ...)
>> ->shrink_list(struct list_head *, ...)
>>
>>which is fairly irrational.
>>
>>Rename things so that we have
>>
>> try_to_free_pages
>> ->shrink_zones(struct zone **zones, ..)
>> ->shrink_zone(struct zone *, ...)
>> ->do_shrink_zone(struct zone *, ...)
>> ->shrink_page_list(struct list_head *, ...)
>
>
> Every time I read this part it annoys me. Thanks.
I don't much care, but if there is renaming afoot, I'd vote for
->shrink_zones(struct zone **zones, ..)
->shrink_zone(struct zone *, ...)
->shrink_inactive_list(struct zone *, ...)
->shrink_page_list(struct list_head *, ...)
->shrink_active_list (alternatively, leave as refill_inactive_list)
shrink_zone and do_shrink_zone don't really say any more to me than
shrink_zone and shrink_cache.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-02-15 3:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602120605.k1C65QFE028051@shell0.pdx.osdl.net>
2006-02-15 2:47 ` + vmscan-rename-functions.patch added to -mm tree Coywolf Qi Hunt
2006-02-15 3:09 ` Nick Piggin [this message]
2006-02-15 6:46 ` Peter Zijlstra
2006-02-15 8:35 ` Nick Piggin
2006-02-15 11:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F29B84.6020009@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=coywolf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox