public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>
Subject: Re: [RFC][PATCH 0/4] PCI legacy I/O port free driver
Date: Wed, 15 Feb 2006 12:16:18 +0900	[thread overview]
Message-ID: <43F29D02.1090606@jp.fujitsu.com> (raw)
In-Reply-To: <p7364ni475t.fsf@verdi.suse.de>

Andi Kleen wrote:
> Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> writes:
> 
> 
>>I encountered a problem that some PCI devices don't work on my system
>>which have huge number of PCI devices.
> 
> 
> Is that a large IA64 system?
> 

Yes. My IA64 system can have maximum 128 PCI slots, but
currently many of devices on those slots don't work...

> [...]
> 
> The basic concept looks good to me, but I would suggest you use
> the Linux bitmap functions (DECLARE_BITMAP(), set_bit, test_bit etc.)
> instead of open coding all that.
> 
> And for the e1000 change - instead of adding a big switch with
> magic numbers that will likely bitrot it's better to use 
> the driver_data field in pci_device_id for such device specific flags.
> 

I see.
I will try to fix my patches based on your suggestion.

Thanks,
Kenji Kaneshige


      reply	other threads:[~2006-02-15  3:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14  6:03 [RFC][PATCH 0/4] PCI legacy I/O port free driver Kenji Kaneshige
2006-02-14  6:06 ` [RFC][PATCH 1/4] PCI legacy I/O port free driver - Introduce pci_set_bar_mask*() Kenji Kaneshige
2006-02-15  5:07   ` Andrew Morton
2006-02-15  6:03     ` Kenji Kaneshige
2006-02-15  9:07       ` Russell King
2006-02-15 12:33         ` Kenji Kaneshige
2006-02-14  6:07 ` [RFC][PATCH 2/4] PCI legacy I/O port free driver - Update Documantion/pci.txt Kenji Kaneshige
2006-02-14  6:09 ` [RFC][PATCH 3/4] PCI legacy I/O port free driver - Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-02-14  6:10 ` [RFC][PATCH 4/4] PCI legacy I/O port free driver - Make Emulex lpfc " Kenji Kaneshige
2006-02-14  9:32 ` [RFC][PATCH 0/4] PCI legacy I/O port free driver Andi Kleen
2006-02-15  3:16   ` Kenji Kaneshige [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F29D02.1090606@jp.fujitsu.com \
    --to=kaneshige.kenji@jp.fujitsu.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox