public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: Kouji Toriatama <toriatama@inter7.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PPP with PCMCIA modem stalls on 2.6.10 or later
Date: Thu, 16 Feb 2006 10:24:55 -0600	[thread overview]
Message-ID: <43F4A757.4000709@microgate.com> (raw)
In-Reply-To: <20060217.010919.121148551.toriatama@inter7.jp>

Kouji Toriatama wrote:
> ------------------------------------------------------------------
> Feb 16 23:52:40 moka kernel: receive_chars:flip full:low_latency=0
> Feb 16 23:52:40 moka kernel: receive_chars:flip full:discard char
> ------------------------------------------------------------------
> I have got this pair of two lines many times while running the
> wget command.
...
> With 'low_latency' option in 2.6.15 with your patch, the problem
> did not occur and no output from syslog.

Good, the problem is identified:
The old flip buffer code can't keep up unless
it processes received data directly in
the ISR (2.6.9 or 2.6.10+ with low_latency)
instead of in scheduled work (2.6.10+ without low_latency).

The discarded receive chars causes dropped frames
in ppp_async and stalls in data transfer.

I don't remember the details, but I think it is
safe to run low_latency on a uniprocessor.

> I have tried 2.6.16-rc3.  With or without 'low_latency' option,
> the problem did not occur.  It seems to work fine!  I will use
> 2.6.16-rc3 or later.

Alan's new tty buffering code safely handles
high receive rates without data loss, so the
low_latency flag is not necessary.

> If you have any additional plan to pin down this problem, I will
> try your patch.

The fix is already present in 2.6.16 series, so there
is nothing to patch. If you wish to run 2.6.10-2.6.15
you should be able to safely use low_latency on
a uniprocessor machine.

-- 
Paul Fulghum
Microgate Systems, Ltd.

      reply	other threads:[~2006-02-16 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-13 14:16 PPP with PCMCIA modem stalls on 2.6.10 or later Kouji Toriatama
2006-02-13 20:51 ` Paul Fulghum
2006-02-14 15:57   ` Kouji Toriatama
2006-02-14 17:12     ` Paul Fulghum
2006-02-15 13:11       ` Kouji Toriatama
2006-02-15 16:02         ` Paul Fulghum
2006-02-16 16:09           ` Kouji Toriatama
2006-02-16 16:24             ` Paul Fulghum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F4A757.4000709@microgate.com \
    --to=paulkf@microgate.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toriatama@inter7.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox