Re: [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles

[Tilman Schmidt <tilman@imap.cc>]

[-- Attachment #1: Type: text/plain, Size: 2033 bytes --]

On 15.02.2006 04:19, Greg KH wrote:
> On Sat, Feb 11, 2006 at 03:52:27PM +0100, Hansjoerg Lipp wrote:
> 
>>From: Tilman Schmidt <tilman@imap.cc>, Hansjoerg Lipp <hjlipp@web.de>
>>
>>This patch prepares the kernel build infrastructure for addition of the
>>Gigaset ISDN drivers. It creates a Makefile and Kconfig file for the
>>Gigaset driver and hooks them into those of the isdn4linux subsystem.
>>It also adds a MAINTAINERS entry for the driver.
>>
>>This patch depends on patches 2 to 9 of the present set, as without the
>>actual source files, activating the options added here will cause the
>>kernel build to fail.
> 
> Care to redo that and add the Makefile change at the same time as the
> driver goes into the tree?  We don't want to break the buid for a
> specific patch.

I'm afraid I don't quite understand what you'd like us to do. Should we
resubmit the whole driver as a single patch? If so, how do we get it
past the lkml size limit, and how do we indicate that this replaces,
instead of going on top of, our 11 Feb 2006 submission in the -mm tree?
Alternatively, would it suffice to make sure that part 1 goes into the
tree after all the others? If so, how would we achieve that?

Also, I'm a bit unsure how this comment relates to the one by Andrew
Morton dated 12 Feb 2006 02:29:21 -0800 in which he writes:

> This means that the patches should go into git in a single commit, so that
> we don't have a non-compiling tree at any step.   That's not a problem.

That seems to indicate that the problem is already being taken care of,
and if so, I'd certainly not want to interfere with that.

As to your other comments, they are well taken, and we are preparing a
patch against 2.6.16-rc3-mm1 which we'll submit as soon as the present
issue is sorted out.

Regards
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]