public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Jim Duchek <jim.duchek@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: page_order private bit causes problems with dma_alloc_coherent?
Date: Mon, 20 Feb 2006 08:58:50 +0900	[thread overview]
Message-ID: <43F9063A.9090700@jp.fujitsu.com> (raw)
In-Reply-To: <dead81ad0602190139t20b3805bt@mail.gmail.com>

Jim Duchek wrote:
> I'm attempting to debug a problem where pci_free_consistent causes a spewage
> of bad_page's due to the LG_private bit being set.  The remove goes through
> free_pages_ok, which does the free_page_check (which errors on the private
> bit) _BEFORE_ free_pages_bulk (which removes the private bit)
> 

When page is free , page_count(page) == 0. But this just means page is 'free'.
To show page is a head of buddy (contiguous pages of 2^order pages), order is
stored into page->private. To show page->private has a valid 'order', PG_private
is used.

See page_is_buddy() function.

> I'm not entirely sure why the pages are getting this bit -- this is a DRI
> driver and the bits don't get added during the whole time I'm running an
> application -- they get added shortly before I kill the GL client.  Any
> hints?  Is there a way to force pages never to use the page_order stuff?
> Should free_pages_check not consider the private bit such a bad thing?
> Should I just hack in something where I remove all the bits right before I
> do my free? :)
> 
I think removing PG_private before freeing is sane.
The page is free, so it's needless to use PG_private bit when free_pages() is called.

Thanks,
-- Kame


           reply	other threads:[~2006-02-19 23:57 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <dead81ad0602190139t20b3805bt@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F9063A.9090700@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=jim.duchek@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox