From: Michael Heyse <mhk@designassembly.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: [SOLVED] Re: which one is broken: VIA padlock aes or aes_i586?
Date: Wed, 22 Feb 2006 13:32:20 +0100 [thread overview]
Message-ID: <43FC59D4.2090208@designassembly.de> (raw)
In-Reply-To: <20060222114531.GA4170@gondor.apana.org.au>
I found the problem, it's a typo in drivers/crypto/padlock-aes.c (introduced probably in the "[CRYPTO] Use standard byte order macros wherever possible" patch) and only happens with 256 bit keys.
it says below the "case 32:"
E_KEY[4] = le32_to_cpu(in_key[4]);
E_KEY[5] = le32_to_cpu(in_key[5]);
E_KEY[6] = le32_to_cpu(in_key[6]);
t = E_KEY[7] = le32_to_cpu(in_key[7]);
but it should be
E_KEY[4] = le32_to_cpu(key[4]);
E_KEY[5] = le32_to_cpu(key[5]);
E_KEY[6] = le32_to_cpu(key[6]);
t = E_KEY[7] = le32_to_cpu(key[7]);
Now it's working!
Michael
next prev parent reply other threads:[~2006-02-22 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 12:27 which one is broken: VIA padlock aes or aes_i586? Michael Heyse
2006-02-22 1:31 ` Herbert Xu
2006-02-22 11:45 ` Herbert Xu
2006-02-22 12:05 ` Michael Heyse
2006-02-22 12:32 ` Michael Heyse [this message]
2006-02-22 12:43 ` [SOLVED] " Herbert Xu
2006-02-22 11:49 ` Michael Heyse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FC59D4.2090208@designassembly.de \
--to=mhk@designassembly.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox