From: Zach Brown <zab@zabbo.net>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/13] maestro3 vfree NULL check fixup
Date: Fri, 24 Feb 2006 13:09:41 -0800 [thread overview]
Message-ID: <43FF7615.8020504@zabbo.net> (raw)
In-Reply-To: <200602242148.27855.jesper.juhl@gmail.com>
Jesper Juhl wrote:
> vfree() checks for NULL, no need to do it explicitly.
> static void free_dsp_suspendmem(struct m3_card *card)
> {
> - if(card->suspend_mem)
> - vfree(card->suspend_mem);
> + vfree(card->suspend_mem);
> }
eh, I'd just get rid of the helper and call vfree() from both sites.
- z
next prev parent reply other threads:[~2006-02-24 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 20:48 [PATCH 07/13] maestro3 vfree NULL check fixup Jesper Juhl
2006-02-24 21:09 ` Zach Brown [this message]
2006-02-24 21:17 ` Jesper Juhl
2006-02-24 21:18 ` Jesper Juhl
2006-02-24 21:22 ` Jesper Juhl
2006-02-24 21:25 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FF7615.8020504@zabbo.net \
--to=zab@zabbo.net \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox