From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DATE_IN_PAST_06_12, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CAFC43387 for ; Sat, 22 Dec 2018 17:01:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A3F921A48 for ; Sat, 22 Dec 2018 17:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389511AbeLVRBY (ORCPT ); Sat, 22 Dec 2018 12:01:24 -0500 Received: from ozlabs.org ([203.11.71.1]:33249 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731913AbeLVRBE (ORCPT ); Sat, 22 Dec 2018 12:01:04 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 43MLSt1FF1z9sPV; Sat, 22 Dec 2018 20:54:53 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 8c6c942d33f2a79439e86f8f406afae40a5bc767 X-Patchwork-Hint: ignore In-Reply-To: <1545273771-131851-1-git-send-email-yuehaibing@huawei.com> To: YueHaibing , Russell Currey , Sam Bobroff , Oliver O'Halloran , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org, YueHaibing , linux-kernel@vger.kernel.org Subject: Re: [-next] powerpc/eeh: Fix debugfs_simple_attr.cocci warnings Message-Id: <43MLSt1FF1z9sPV@ozlabs.org> Date: Sat, 22 Dec 2018 20:54:53 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-12-20 at 02:42:51 UTC, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing > Acked-by: Russell Currey Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/8c6c942d33f2a79439e86f8f406afa cheers