From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDBC186A for ; Thu, 23 Jan 2025 10:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737628236; cv=none; b=stoklF9wYsUB2e09Cp4BEz/wrjpwG1CwBc24k3GZHtkl01wmp0ZqiV+Hh2m7UpDxEkLZbZSK5SSDbfjEAi1Q0rO9ElHEcqfYWNhUS8FtQZdzAmGWLQ6EdBUz7sTMUOncMttjgz0+Zd2GxWKpJ66DNZzU2qo1ldi/PlDoOxmPcp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737628236; c=relaxed/simple; bh=DUe8ReHe6otA8p88OTdvDZeROihhRDKcxeDKtLYf1wY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PSIzvy11ZmNPBCSLBCvX/0k09O/UqF5rtUJ4TA57c0BkWmoL0b9mOSJ6mQSYEDCI/vtAyyHcaX3BgmwQUzisbtZhjupVjMbzzV8HPPWO4oZinIkW49kG4z7PL0pXDRSg4iiwS1cuqETd9fAq7rx79fm9oPBDugpqDZ2tAGbXucY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Sri3esO2; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Sri3esO2" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50N7Y7ZY031746; Thu, 23 Jan 2025 10:30:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ElgwOm g4zurIGAG33KrdB9qV6Qn3O8n1JN+1ytDaaQ4=; b=Sri3esO25xNK9bRMTJPS/L dLLKCccE9DfluAZVF6kSh9DAvvxPWazNbPArz+7XDMi3tXV2HXNsl1nmkdv588Vy N4UpaGWUEfDtqzKkPBz/PaURBrDU/g+aMd6v9hLIjNJfPJojUtWWHs5u7Y1Yybkg 0Tfk+QfkpMqAwxTyW34ZJ26qG9qK4n2labKGi+PV962XnC3Ru8KPtcZhbikGhMbD Ju+ZpHu46JcmPBxvYSsfoBHdD/Gngqu07S7U2CUGnrFiikJtPuIWe92j6GNldUwQ EHTSDyDtWskl3OiLhVXXQKWgmVDT/yfF/RBTuVWEQEYGpQBalFGcs/EKsL9WZ5jA == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44bhfpgtfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 10:30:20 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50N7hopa022642; Thu, 23 Jan 2025 10:30:19 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448r4kcyag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 10:30:19 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50NAUGO354985174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2025 10:30:16 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 186CA2004F; Thu, 23 Jan 2025 10:30:16 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5429D20040; Thu, 23 Jan 2025 10:30:14 +0000 (GMT) Received: from [9.203.114.244] (unknown [9.203.114.244]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Jan 2025 10:30:14 +0000 (GMT) Message-ID: <43aeaa2c-c266-4d6e-921d-80b99ceb418b@linux.ibm.com> Date: Thu, 23 Jan 2025 16:00:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] powerpc/kdump: preserve user-specified memory limit To: Sourabh Jain , linuxppc-dev@lists.ozlabs.org Cc: Andrew Morton , Baoquan he , Madhavan Srinivasan , Michael Ellerman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Mahesh Salgaonkar References: <20250121115442.1278458-1-sourabhjain@linux.ibm.com> <20250121115442.1278458-5-sourabhjain@linux.ibm.com> Content-Language: en-US From: Hari Bathini In-Reply-To: <20250121115442.1278458-5-sourabhjain@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: znjyydUgdRDLatsnRWlibUpXi4ANAtb7 X-Proofpoint-ORIG-GUID: znjyydUgdRDLatsnRWlibUpXi4ANAtb7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-23_04,2025-01-22_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501230080 On 21/01/25 5:24 pm, Sourabh Jain wrote: > Commit 59d58189f3d9 ("crash: fix crash memory reserve exceed system > memory bug") fails crashkernel parsing if the crash size is found to be > higher than system RAM, which makes the memory_limit adjustment code > ineffective due to an early exit from reserve_crashkernel(). > > Regardless lets not violated the user-specified memory limit by s/violated/violate/ > adjusting it. Remove this adjustment to ensure all reservations stay > within the limit. Commit f94f5ac07983 ("powerpc/fadump: Don't update > the user-specified memory limit") did the same for fadump. > Acked-by: Hari Bathini > Cc: Andrew Morton > Cc: Baoquan he > Cc: Hari Bathini > CC: Madhavan Srinivasan > Cc: Michael Ellerman > Cc: kexec@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Reviewed-by: Mahesh Salgaonkar > Signed-off-by: Sourabh Jain > --- > arch/powerpc/kexec/core.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/powerpc/kexec/core.c b/arch/powerpc/kexec/core.c > index b8333a49ea5d..4945b33322ae 100644 > --- a/arch/powerpc/kexec/core.c > +++ b/arch/powerpc/kexec/core.c > @@ -150,14 +150,6 @@ void __init reserve_crashkernel(void) > return; > } > > - /* Crash kernel trumps memory limit */ > - if (memory_limit && memory_limit <= crashk_res.end) { > - memory_limit = crashk_res.end + 1; > - total_mem_sz = memory_limit; > - printk("Adjusted memory limit for crashkernel, now 0x%llx\n", > - memory_limit); > - } > - > printk(KERN_INFO "Reserving %ldMB of memory at %ldMB " > "for crashkernel (System RAM: %ldMB)\n", > (unsigned long)(crash_size >> 20),