From: Krzysztof Kozlowski <krzk@kernel.org>
To: marc.ferland@gmail.com, krzysztof.kozlowski@linaro.org
Cc: gregkh@linuxfoundation.org, marc.ferland@sonatest.com,
jeff.dagenais@gmail.com, rdunlap@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] w1: ds2433: rename W1_EEPROM_DS2433
Date: Mon, 20 Nov 2023 10:24:18 +0100 [thread overview]
Message-ID: <43da86af-053f-462b-9a61-27bfac6b41aa@kernel.org> (raw)
In-Reply-To: <20231117192909.98944-3-marc.ferland@sonatest.com>
On 17/11/2023 20:29, marc.ferland@gmail.com wrote:
> From: Marc Ferland <marc.ferland@sonatest.com>
>
> Rename the W1_EEPROM_DS2433 define to W1_F23_EEPROM_DS2433 to make it
> clear it is associated with family 0x23.
>
> This is ground work for supporting both the ds2433 and the ds28ec20.
Why do you need to "associate" it with family 0x23? Can ds2433 be 0x43?
If not, family is irrelevant information.
>
> Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
> ---
> drivers/w1/slaves/w1_ds2433.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 19:29 [PATCH 1/7] w1: ds2433: remove unused definition marc.ferland
2023-11-17 19:29 ` [PATCH 2/7] w1: ds2433: add support for registering multiple families marc.ferland
2023-11-20 9:22 ` Krzysztof Kozlowski
2023-11-17 19:29 ` [PATCH 3/7] w1: ds2433: rename W1_EEPROM_DS2433 marc.ferland
2023-11-20 9:24 ` Krzysztof Kozlowski [this message]
2023-11-17 19:29 ` [PATCH 4/7] w1: ds2433: introduce a configuration structure marc.ferland
2023-11-18 6:33 ` kernel test robot
2023-11-17 19:29 ` [PATCH 5/7] w1: ds2433: rename w1_f23_data to w1_data marc.ferland
2023-11-20 9:24 ` Krzysztof Kozlowski
2023-11-17 19:29 ` [PATCH 6/7] w1: ds2433: add support for ds28ec20 eeprom marc.ferland
2023-11-20 9:26 ` Krzysztof Kozlowski
2023-11-21 16:37 ` Marc Ferland
2023-11-17 19:29 ` [PATCH 7/7] w1: ds2490: support buffer sizes bigger than 128 marc.ferland
2023-11-27 20:18 ` [PATCH v2 0/5] Add support for the ds28ec20 one-wire eeprom marc.ferland
2023-11-27 20:18 ` [PATCH v2 1/5] w1: ds2490: support block sizes larger than 128 bytes in ds_read_block marc.ferland
2023-11-27 20:18 ` [PATCH v2 2/5] w1: ds2433: remove unused definition marc.ferland
2023-11-27 20:18 ` [PATCH v2 3/5] w1: ds2433: introduce a configuration structure marc.ferland
2023-11-27 20:18 ` [PATCH v2 4/5] w1: ds2433: use the kernel bitmap implementation marc.ferland
2023-11-27 20:18 ` [PATCH v2 5/5] w1: ds2433: add support for ds28ec20 eeprom marc.ferland
2023-11-28 9:08 ` [PATCH v2 0/5] Add support for the ds28ec20 one-wire eeprom Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43da86af-053f-462b-9a61-27bfac6b41aa@kernel.org \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.dagenais@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.ferland@gmail.com \
--cc=marc.ferland@sonatest.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox