From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbdKBIGT (ORCPT ); Thu, 2 Nov 2017 04:06:19 -0400 Received: from mout.web.de ([212.227.15.3]:60515 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbdKBIAe (ORCPT ); Thu, 2 Nov 2017 04:00:34 -0400 Subject: [PATCH 2/3] regulator/core: Improve a size determination in four functions From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Liam Girdwood , Mark Brown Cc: LKML References: <471498fb-58af-46d4-2150-614c0f9cdc22@users.sourceforge.net> Message-ID: <43dd60ac-bd16-76aa-ea71-f4e647b54ad3@users.sourceforge.net> Date: Thu, 2 Nov 2017 09:00:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <471498fb-58af-46d4-2150-614c0f9cdc22@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:110fvW3EeuEdjBQpGaqIkl/HKXqsIfcSeEVUbOeXPoZS6zwkzDR +Pw1Y0ct40sUr/PoXUG9OhR6NvYJ/uzmX1W6jHGdvMsqgoH/uZh9/0NfUXafWlvJNVv4mBg ygenXJgKH5NeelNb3I3yA6qFw0m7rLG4QNDpRRnO3lLE64zF1rYR3cDS39uTW2In7nERHyw DbdeywBV0BEPS0g0Ov4ZQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:dmA5ct2Hh7U=:JhNtqw+/imXY3HQqJgAHcp J+wTPjtEJutP5ta6vTJ8ONPpf6iDehuMCmxTHEa3dYGEjBIRQX0jZchN4QPcexGL76xAkTM5m E2l473ElyfoqWDszfQr2D+FOBilpp1lIGWgU3HQ2vkG8gHpUZEOWwMZosrc7B856vIsELMgt7 ARA3WzdyD2lQn4dJsdD7mjLwVuQ+9LmBgVbqLw/sQQcVTee/mcqtxzL/5WRpjOXAXxYTki8Dt vB3Xf+lEvvVlsOoIFkph9cj6jrhQnSqAp1e6GuQXIdk0mNfWA2xESiHQaBgMtigW6QxbV5NZq u4y5V4Fdg+dIPiiqT22ITQNKpJz37lrO0PZQbJtRdU0YEAZmv1X36un360BkGUkBbW3D+W0mG vg5aiOVuC49IGTOUacdMSBZsPTlYD7Kj/00MoVTsTExxUx3ToRKL6QcmT0z/cJVeboyjPB7tR xGOqZr7rujRry7idURaomFD9L2uq0+EUtGOvjclKtv2kX8AHG/fjMKW7GgdIEcKL5wT9k/LaW dqzZOzCY2skgHv9fatwonRjnC0YCX75YPu8SOD5iv7QkayQHJWBKrR3Nk+a7WCCuDXe82skMs 4gHHE9EfSdClKaQ0TX47l5eMfpYiibo/EHD8z0yhmGXamPDKEk6ancMEz2w0LLaUsHKt4Z5jp LPQExRyXJv1+SJBey7h46xqz81Wqod8xlBuDWp+5vDZourZpfuHdkR3dQ8QiQpZ8XNDMCReoW 6s3zSBJeAI7Dj22BeCCuSg3o82Z5Di/5f7G34XHsTvQ4L8db+PjJk3Pc0B68lqng7hqpE3yvS VJDGP4IxUeTzz5UqjQHwK23IE2h8PwqsbOB+veVReboU1jf7lI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 1 Nov 2017 22:30:10 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/regulator/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 14fdf2f17a62..28859c186c9f 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1223,7 +1223,7 @@ static int set_consumer_device_supply(struct regulator_dev *rdev, return -EBUSY; } - node = kzalloc(sizeof(struct regulator_map), GFP_KERNEL); + node = kzalloc(sizeof(*node), GFP_KERNEL); if (node == NULL) return -ENOMEM; @@ -1833,7 +1833,7 @@ int regulator_register_supply_alias(struct device *dev, const char *id, if (map) return -EEXIST; - map = kzalloc(sizeof(struct regulator_supply_alias), GFP_KERNEL); + map = kzalloc(sizeof(*map), GFP_KERNEL); if (!map) return -ENOMEM; @@ -1964,7 +1964,7 @@ static int regulator_ena_gpio_request(struct regulator_dev *rdev, if (ret) return ret; - pin = kzalloc(sizeof(struct regulator_enable_gpio), GFP_KERNEL); + pin = kzalloc(sizeof(*pin), GFP_KERNEL); if (pin == NULL) { gpio_free(config->ena_gpio); return -ENOMEM; @@ -4011,7 +4011,7 @@ regulator_register(const struct regulator_desc *regulator_desc, return ERR_PTR(-EINVAL); } - rdev = kzalloc(sizeof(struct regulator_dev), GFP_KERNEL); + rdev = kzalloc(sizeof(*rdev), GFP_KERNEL); if (rdev == NULL) return ERR_PTR(-ENOMEM); -- 2.14.3