From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Arnd Bergmann <arnd@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Martin KaFai Lau <martin.lau@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
bpf@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher
Date: Mon, 17 Feb 2025 14:03:27 +0000 [thread overview]
Message-ID: <43fa75f9-e6e3-4d80-b3b0-a97387fb2a07@linux.dev> (raw)
In-Reply-To: <20250217125601.3408746-1-arnd@kernel.org>
On 17/02/2025 12:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All modules should have a description, building with extra warnings
> enabled prints this outfor the for bpf_crypto_skcipher module:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o
>
> Add a description line.
>
> Fixes: fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> crypto/bpf_crypto_skcipher.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/bpf_crypto_skcipher.c b/crypto/bpf_crypto_skcipher.c
> index b5e657415770..a88798d3e8c8 100644
> --- a/crypto/bpf_crypto_skcipher.c
> +++ b/crypto/bpf_crypto_skcipher.c
> @@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
> module_init(bpf_crypto_skcipher_init);
> module_exit(bpf_crypto_skcipher_exit);
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Symmetric key cipher support for BPF");
Thanks for fixing!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2025-02-17 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:55 [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher Arnd Bergmann
2025-02-17 14:03 ` Vadim Fedorenko [this message]
2025-03-02 8:04 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fa75f9-e6e3-4d80-b3b0-a97387fb2a07@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox