* [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher
@ 2025-02-17 12:55 Arnd Bergmann
2025-02-17 14:03 ` Vadim Fedorenko
2025-03-02 8:04 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-02-17 12:55 UTC (permalink / raw)
To: Vadim Fedorenko, Herbert Xu, David S. Miller, Martin KaFai Lau
Cc: Arnd Bergmann, bpf, linux-crypto, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
All modules should have a description, building with extra warnings
enabled prints this outfor the for bpf_crypto_skcipher module:
WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o
Add a description line.
Fixes: fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
crypto/bpf_crypto_skcipher.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/bpf_crypto_skcipher.c b/crypto/bpf_crypto_skcipher.c
index b5e657415770..a88798d3e8c8 100644
--- a/crypto/bpf_crypto_skcipher.c
+++ b/crypto/bpf_crypto_skcipher.c
@@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
module_init(bpf_crypto_skcipher_init);
module_exit(bpf_crypto_skcipher_exit);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Symmetric key cipher support for BPF");
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher
2025-02-17 12:55 [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher Arnd Bergmann
@ 2025-02-17 14:03 ` Vadim Fedorenko
2025-03-02 8:04 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-02-17 14:03 UTC (permalink / raw)
To: Arnd Bergmann, Herbert Xu, David S. Miller, Martin KaFai Lau
Cc: Arnd Bergmann, bpf, linux-crypto, linux-kernel
On 17/02/2025 12:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All modules should have a description, building with extra warnings
> enabled prints this outfor the for bpf_crypto_skcipher module:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o
>
> Add a description line.
>
> Fixes: fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> crypto/bpf_crypto_skcipher.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/bpf_crypto_skcipher.c b/crypto/bpf_crypto_skcipher.c
> index b5e657415770..a88798d3e8c8 100644
> --- a/crypto/bpf_crypto_skcipher.c
> +++ b/crypto/bpf_crypto_skcipher.c
> @@ -80,3 +80,4 @@ static void __exit bpf_crypto_skcipher_exit(void)
> module_init(bpf_crypto_skcipher_init);
> module_exit(bpf_crypto_skcipher_exit);
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Symmetric key cipher support for BPF");
Thanks for fixing!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher
2025-02-17 12:55 [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher Arnd Bergmann
2025-02-17 14:03 ` Vadim Fedorenko
@ 2025-03-02 8:04 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2025-03-02 8:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vadim Fedorenko, David S. Miller, Martin KaFai Lau, Arnd Bergmann,
bpf, linux-crypto, linux-kernel
On Mon, Feb 17, 2025 at 01:55:55PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> All modules should have a description, building with extra warnings
> enabled prints this outfor the for bpf_crypto_skcipher module:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in crypto/bpf_crypto_skcipher.o
>
> Add a description line.
>
> Fixes: fda4f71282b2 ("bpf: crypto: add skcipher to bpf crypto")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> crypto/bpf_crypto_skcipher.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-02 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 12:55 [PATCH] crypto: bpf - Add MODULE_DESCRIPTION for skcipher Arnd Bergmann
2025-02-17 14:03 ` Vadim Fedorenko
2025-03-02 8:04 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox