From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Geoff Levand <geoff@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: powerpc/ps3: Use struct_size() in kzalloc()
Date: Thu, 24 Jan 2019 14:40:20 +1100 (AEDT) [thread overview]
Message-ID: <43lSbT1lyfz9sN8@ozlabs.org> (raw)
In-Reply-To: <20190108210010.GA980@embeddedor>
On Tue, 2019-01-08 at 21:00:10 UTC, "Gustavo A. R. Silva" wrote:
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> void *entry[];
> };
>
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>
> Instead of leaving these open-coded and prone to type mistakes, we can now
> use the new struct_size() helper:
>
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/31367b9a01d6a3f4f77694bd44f547d6
cheers
next prev parent reply other threads:[~2019-01-24 3:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 21:00 [PATCH] powerpc/ps3: Use struct_size() in kzalloc() Gustavo A. R. Silva
2019-01-16 17:21 ` Geoff Levand
2019-01-16 17:46 ` Gustavo A. R. Silva
2019-01-24 3:40 ` Michael Ellerman [this message]
2019-01-24 17:38 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43lSbT1lyfz9sN8@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox