From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: jiffies_64 vs. jiffies
Date: Thu, 02 Mar 2006 02:00:16 +1100 [thread overview]
Message-ID: <4405B700.1080607@yahoo.com.au> (raw)
In-Reply-To: <20060301.235750.25910018.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
>>>>>>On Wed, 01 Mar 2006 23:52:37 +1100, Nick Piggin <nickpiggin@yahoo.com.au> said:
>
>
>>>void do_timer(struct pt_regs *regs)
>>>{
>>>- jiffies_64++;
>>>- update_times();
>>>+ update_times(++jiffies_64);
>>> softlockup_tick(regs);
>>>}
>
>
> nick> jiffies_64 is not volatile so you should not have to obfuscate
> nick> the code like this.
>
> Well, do you mean it should be like this ?
>
> jiffies_64++;
> update_times(jiffies_64);
>
Yeah. It makes your patch a line smaller too!
> Thanks for your comments.
Oh it was nothing really ;)
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-01 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 5:44 jiffies_64 vs. jiffies Atsushi Nemoto
2006-03-01 12:05 ` Atsushi Nemoto
2006-03-01 12:52 ` Nick Piggin
2006-03-01 14:57 ` Atsushi Nemoto
2006-03-01 15:00 ` Nick Piggin [this message]
2006-03-01 16:13 ` Atsushi Nemoto
2006-03-03 4:06 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4405B700.1080607@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox