From: Hans Reiser <reiser@namesys.com>
To: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Reiserfs mail-list <Reiserfs-List@namesys.com>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [Fwd: Re: [PATCH] reiserfs: use balance_dirty_pages_ratelimited_nr in reiserfs_file_write]
Date: Thu, 02 Mar 2006 10:24:45 -0800 [thread overview]
Message-ID: <4407386D.4070008@namesys.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
I suspect that when someone did the search and replace when creating
balance_dirty_pages_ratelimited_nr they failed to read the code and
realize this code path was already effectively ratelimited. The result
is they made it excessively infrequent (every 1MB if ratelimit is 8) in
its calling balance_dirty_pages.
If anyone has ever seen this as an actual problem on a real system, I
would be curious to hear of it.
Hans
[-- Attachment #2: Re: [PATCH] reiserfs: use balance_dirty_pages_ratelimited_nr in reiserfs_file_write --]
[-- Type: message/rfc822, Size: 2680 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 233 bytes --]
Hans,
The patch works, however its effect is not visible.
Would you please forward it?
On Tuesday 28 February 2006 22:16, E.Gryaznova wrote:
> Zam said me about this patch, it is in my todo list for tomorrow.
>
> Thanks,
> Lena
>
[-- Attachment #2.1.2: reiserfs-reiserfs_file_write-use-balance_dirty_pages_ratelimited_nr.diff~ --]
[-- Type: application/x-trash, Size: 587 bytes --]
next reply other threads:[~2006-03-02 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 18:24 Hans Reiser [this message]
2006-03-02 23:08 ` [Fwd: Re: [PATCH] reiserfs: use balance_dirty_pages_ratelimited_nr in reiserfs_file_write] Andrew Morton
2006-03-03 17:24 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4407386D.4070008@namesys.com \
--to=reiser@namesys.com \
--cc=Reiserfs-List@namesys.com \
--cc=akpm@osdl.org \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).