From: Sam Vilain <sam@vilain.net>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Fwd: [PATCH 3/5] NFS: Abstract out namespace initialisation [try #2]]
Date: Fri, 03 Mar 2006 08:52:29 +1300 [thread overview]
Message-ID: <44074CFD.7050708@vilain.net> (raw)
In-Reply-To: <3254.1141299348@warthog.cambridge.redhat.com>
David Howells wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
>>>The attached patch abstracts out the namespace initialisation so that
>>>temporary namespaces can be set up elsewhere.
>>Definitily shouldb't be inline. And until you have a second caller
>>it's utterly pointless. So NACK for now.
> I presume from that you didn't notice that the second caller was in patch 5/5?
AIUI, each patch must stand on its own in every regard. I guess you
need to make it inline in the later patch - or not at all given the
marginal speed difference vs. core size increase.
Sam.
next prev parent reply other threads:[~2006-03-02 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 21:37 [Fwd: [PATCH 3/5] NFS: Abstract out namespace initialisation [try #2]] Sam Vilain
2006-03-02 8:44 ` Christoph Hellwig
2006-03-02 11:35 ` David Howells
2006-03-02 19:52 ` Sam Vilain [this message]
2006-03-02 21:12 ` David Howells
2006-03-02 21:53 ` Sam Vilain
2006-03-05 0:34 ` Andrew Morton
2006-03-03 16:52 ` J. Bruce Fields
2006-03-02 20:00 ` Sam Vilain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44074CFD.7050708@vilain.net \
--to=sam@vilain.net \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox