Re: [patch 2.6.16-rc5-mm2] sched_cleanup-V17 - task throttling patch 1 of 2

Peter Williams
2006-03-04T21:37:52Z

Mike Galbraith wrote:
> On Sat, 2006-03-04 at 10:58 +1100, Peter Williams wrote:
>
>
>>If you're going to manage the time slice in nanoseconds why not do it
>>properly? I presume you've held back a bit in case you break something?
>>
>
>
> Do you mean the < NS_TICK thing? The spare change doesn't go away.

Not exactly. I mean "Why calculate time slice in jiffies and convert to
nanoseconds? Why not just do the calculation in nanoseconds?"

>
>
>>If it helps, the smpnice balancing code's use of static_prio_timeslice()
>>doesn't really care what units it's return value is in as long as
>>DEF_TIMESLICE is in the same units and contains the size of a time slice
>>allocated to a nice==0 non RT task.
>
>
> Ok, thanks. I wanted to make very certain I couldn't screw it up.
> Still, it's simpler to just leave it in ticks.
>
> -Mike

Peter
--
Peter Williams pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce