Re: [patch 2.6.16-rc5-mm2] sched_cleanup-V17 - task throttling patch 1 of 2

Mike Galbraith
2006-03-05T06:55:00Z

On Sun, 2006-03-05 at 08:37 +1100, Peter Williams wrote:
> Mike Galbraith wrote:
> > On Sat, 2006-03-04 at 10:58 +1100, Peter Williams wrote:
> >
> >
> >>If you're going to manage the time slice in nanoseconds why not do it
> >>properly? I presume you've held back a bit in case you break something?
> >>
> >
> >
> > Do you mean the < NS_TICK thing? The spare change doesn't go away.
>
> Not exactly. I mean "Why calculate time slice in jiffies and convert to
> nanoseconds? Why not just do the calculation in nanoseconds?"

Turns out that my first instinct was right, and there is a good reason
not to. It doesn't improve readability nor do anything functional, it
only adds clutter. I much prefer the look of plain old ticks, and
having nanoseconds only intrude where they're required. I did change
NS_TICK to the less obfuscated (1000000000 / HZ), with task_timeslice()
returning a more readable ticks * NS_TICK conversion.

-Mike