From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7E03115AF for ; Fri, 14 Nov 2025 11:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121231; cv=none; b=cpSAqzjqGKNZPoLM12XjE5NcNqKczk1TX6C3uGZl9IxVh9G7b1ldrYhVvY+R3yENWPrV4wZ52dupnOhRH+HLqW1vwSHSeltw5mtaCt4gDeYrU8lWkyMZERk6GZT26aOneag036SvCcfaNX2nufUvEm092NMsk8HN2NxUPU5DOZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763121231; c=relaxed/simple; bh=VP/S9o9J/KD/XUxwpt99zrmZZpz7S0IRbMjMzPsoOSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n8pJT2yrVfnBAK64ALqctgrdL1ygRFueM3ThzI6ERIXu/qi1Pi54Zgn1SKIh+NRz0Ut6SIVHgqDQ34z61izcqi3MVjkyUoJxkVrOFEfz6ejZKkX9y9BrG0sJgPRdbGSbCK5Cs7QLAW7E/M1Q7Oi6mnX/KVKgGFlNhWoS8jmBP64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nKafAFUN; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nKafAFUN" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b735b7326e5so222636066b.0 for ; Fri, 14 Nov 2025 03:53:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763121228; x=1763726028; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VP/S9o9J/KD/XUxwpt99zrmZZpz7S0IRbMjMzPsoOSE=; b=nKafAFUNTyfJEs4UeuVVly920kgxL5LC1CLyimPMiAL42bsaXBAFLG9fmbCpusQjCN HNxV5Ad1I4q1krtmCkb4jeFg8Re6aodSP5zR6D407RxsYQhFukQwKZ80y0kfHnGwnjsp zrXxldBTIyNrIHjN1MtlmNmsXjvcrzh7uE537ZSxAxop+cWibDB69LJ18ZsMJUXxjKFN fBnWxycJclC+0G9h84bnZxbrrtyiedCHBlJ67y5B+BMejKD1+Q2eedsTx5bAJ0g8QuIV 43hZ4XeN724DlJot+MQfSFn/l6nlNCWlhkkbLEDobbdWNQSpVnJW0mmBV0DBKa864IbH uLCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763121228; x=1763726028; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VP/S9o9J/KD/XUxwpt99zrmZZpz7S0IRbMjMzPsoOSE=; b=dvwrxMMY/1sg99TcSrTV7GtKxHv1zeJIvKJ5gqpHY8WV2mpCVfzhQkcEjybeI7dZUW ZIaLodoOSXPgHHo5HLrHti9tV2RUwoowrpQgTwv6if+sh9H3Q5PMtgCXGe8xMkACsgbc QHhi4LwWiqc3pr+Ik0Xv5fY+ji7qNFI2DcBJ9lc9nmk1PuU7fO9fxJ9vcfU8D2fYKVpA oNEnR1NsiufBs7hhLZvnPF/Lx1qSuNpbo0o6Ow/++0E9ATB39QZsKGFbuaBRNH3y6A5U at9N2Yxc0Xx2/QHNAEiGkZIr7xlZD30pjQrogzxmgt63WR9CaY456RTt26OWoAtNo0DU +hJg== X-Forwarded-Encrypted: i=1; AJvYcCXYPbWaLF8elu7yLkMuuaTmo10rh4iJUCLEozv+Z2W5iZTwuuMDWtJpssgGmKbODTqC8gj5GgcgDRd53Vg=@vger.kernel.org X-Gm-Message-State: AOJu0Yypf1RXyMmI/TR6igmeWrhzY6Bvw5hTMKqHn+pFR1EeTg9/zixm /GkId0HeWSWni4lzH4Sx6OHcuRdZbJco6rYRj1vFhjflhKJg2rH204ZvRoe+IBIXV1LgXA== X-Gm-Gg: ASbGncuVbyiJLt1gNytaGxy+n4pFpJxIo1xNJ/PXowcCqPTSEB8ELuQLeRooVnBVG2V L1R1xsWw29nPAOZ1AQnKZdZgjbRBfc3TTYpCCFFWv9o/NVGly0sLysT1P6NaqaW/IKRrXUaId1e o0bY82Q6xKoIYGMBa/3vQbQm5pCMnW1PtUaVdc0Y6PyNdOu5poigq1mJnr+43XlFKWrJfyiZUis BzSBbPqaJA/AfPNcwSSBFM9HA7O3lnPIwrcia8+L3ppqnp74hsLOJHuXMizVuoY21ucdXchTofa g1NoNN+6vNkSjGQJ1WSWAlRWa0YiFEEbsjnIF7hXNxvu+G0eAGb4eALV5bmHwrZZG5IhJSbqqp8 wTBeMyMY65LXpjQiRdVLY8W3JyN1bmI8zLyLZzIx1DP5+7HRpQTI6fyj/isEA9R1ZFle1BRDNuQ XNNR9PMbyf0w== X-Google-Smtp-Source: AGHT+IH54E7FGmo3MpDUeyRY8KJ2Q5KxiPIF0VY7f8oBWzMrr18NHx1Eipu3902SFP43jzcYqDDYzA== X-Received: by 2002:a17:907:d03:b0:b72:c160:79f with SMTP id a640c23a62f3a-b7348659952mr675243866b.30.1763121227701; Fri, 14 Nov 2025 03:53:47 -0800 (PST) Received: from [192.168.1.12] ([197.46.78.60]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fb12d55sm370517666b.33.2025.11.14.03.53.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 03:53:47 -0800 (PST) Message-ID: <440a71b7-db3b-4374-a2f4-10d99a3b6239@gmail.com> Date: Fri, 14 Nov 2025 13:53:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] posix-timers: Fix potential memory leak in do_timer_create() To: Cyrill Gorcunov Cc: anna-maria@linutronix.de, frederic@kernel.org, tglx@linutronix.de, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, syzbot+9c47ad18f978d4394986@syzkaller.appspotmail.com References: <20251114050621.875131-1-eslam.medhat1993@gmail.com> Content-Language: en-US From: Eslam Khafagy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/14/25 11:29, Cyrill Gorcunov wrote: > On Fri, Nov 14, 2025 at 07:06:21AM +0200, Eslam Khafagy wrote: >> potential memory leak may happen if user space pointer created_timer_id >> is invallid. or the value it points to is invalid. the call will >> prematurely return. >> >> However it doesn't free the memory it allocates with >> alloc_posix_timer(). This patch attemps to fix that. >> >> Reported-and-tested-by: syzbot+9c47ad18f978d4394986@syzkaller.appspotmail.com >> Closes: https://lore.kernel.org/all/69155df4.a70a0220.3124cb.0017.GAE@google.com/T/ >> Fixes: ec2d0c04624b3c8a7eb1682e006717fa20cfbe24 ("posix-timers: Provide a mechanism to allocate a given timer ID") >> Signed-off-by: Eslam Khafagy > Simply move parameters check _before_ new timer allocation please, this way you won't > need new code at all :) :) v2 coming right up.