From: Kirill Korotaev <dev@sw.ru>
To: Jan Blunck <jblunck@suse.de>
Cc: Kirill Korotaev <dev@openvz.org>,
akpm@osdl.org, viro@zeniv.linux.org.uk, olh@suse.de,
neilb@suse.de, bsingharora@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
Date: Thu, 09 Mar 2006 19:18:21 +0300 [thread overview]
Message-ID: <4410554D.2050806@sw.ru> (raw)
In-Reply-To: <20060309160922.GI4243@hasse.suse.de>
> Thanks! I'll send the corrected patch.
> So, everythings fine now?
looks so! Will be glad to Ack/Sign or whatever needed :)))
>>> d_free(dentry);
>>> if (parent != dentry)
>>> dput(parent);
>>> spin_lock(&dcache_lock);
>>>+ sb->s_prunes--;
>>>+ if (likely(!sb->s_prunes))
>>
>><<< Is it possibe to do something like:
>>if (unlikely(!sb->s_root && !sb->s_prunes))
>>?
>
>
> Uh, I forgot about that one. You already complained about that before :(
But I'm not sure it is that simple... s_root is set to NULL w/o locks,
so I wonder whether it is safe to check it here or we can miss some
wakeups...
Thanks,
Kirill
next prev parent reply other threads:[~2006-03-09 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 14:51 [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch) Jan Blunck
2006-03-09 6:33 ` Balbir Singh
2006-03-09 11:00 ` Jan Blunck
2006-03-09 11:21 ` Andrew Morton
2006-03-09 11:58 ` Jan Blunck
2006-03-09 12:53 ` Kirill Korotaev
2006-03-09 14:08 ` Jan Blunck
2006-03-09 14:36 ` Kirill Korotaev
2006-03-09 11:36 ` Balbir Singh
2006-03-09 14:42 ` Kirill Korotaev
2006-03-09 16:09 ` Jan Blunck
2006-03-09 16:18 ` Kirill Korotaev [this message]
2006-03-09 16:39 ` Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4410554D.2050806@sw.ru \
--to=dev@sw.ru \
--cc=akpm@osdl.org \
--cc=bsingharora@gmail.com \
--cc=dev@openvz.org \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=olh@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox