[PATCH] Input: psmouse - disable autoresync

[PATCH] Input: psmouse - disable autoresync

[Dmitry Torokhov]

Automatic resynchronization in psmouse driver causes problems on some
hardware so disable it by default for now. People with KVM switches
that require resync can still enable it via module parameter or sysfs
attribute.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

Unfortunately I could not spend enouggh time during 2.6.16 cycle to resolve
all issues with the code so we better turn it off by default for now.
 

 drivers/input/mouse/psmouse-base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/input/mouse/psmouse-base.c
===================================================================
--- work.orig/drivers/input/mouse/psmouse-base.c
+++ work/drivers/input/mouse/psmouse-base.c
@@ -60,7 +60,7 @@ static unsigned int psmouse_resetafter =
 module_param_named(resetafter, psmouse_resetafter, uint, 0644);
 MODULE_PARM_DESC(resetafter, "Reset device after so many bad packets (0 = never).");
 
-static unsigned int psmouse_resync_time = 5;
+static unsigned int psmouse_resync_time;
 module_param_named(resync_time, psmouse_resync_time, uint, 0644);
 MODULE_PARM_DESC(resync_time, "How long can mouse stay idle before forcing resync (in seconds, 0 = never).");
 

Re: [PATCH] Input: psmouse - disable autoresync

[Mark Lord]

Dmitry Torokhov wrote:
> Automatic resynchronization in psmouse driver causes problems on some
> hardware so disable it by default for now. People with KVM switches
> that require resync can still enable it via module parameter or sysfs
> attribute.

Shouldn't the default be the other way round..
Existing *compatible* behaviour by default,
and those who need it can do psmouse.resync_time=0

????????????????

Re: [PATCH] Input: psmouse - disable autoresync

[Dmitry Torokhov]

On Saturday 11 March 2006 13:49, Mark Lord wrote:
> Dmitry Torokhov wrote:
> > Automatic resynchronization in psmouse driver causes problems on some
> > hardware so disable it by default for now. People with KVM switches
> > that require resync can still enable it via module parameter or sysfs
> > attribute.
> 
> Shouldn't the default be the other way round..
> Existing *compatible* behaviour by default,
> and those who need it can do psmouse.resync_time=0
> 
> ????????????????
> 

Automatic resync code was added at the beginning of 2.6.16 and although it
generally works quite well and usually resolves problems caused by KVMs
resetting mice ther were several reports of it breaking existing setups.
Unfortunately I did not have anough time to resolve the issues in time
for 2.6.16 final and so I think it is the best to disable new code by
default for now. I do not want to revert the changes completely as they
are still useful.

Hope this helps.

-- 
Dmitry

Re: [PATCH] Input: psmouse - disable autoresync

[Mark Lord]

Dmitry Torokhov wrote:
> Automatic resync code was added at the beginning of 2.6.16 and although it
> generally works quite well and usually resolves problems caused by KVMs
> resetting mice ther were several reports of it breaking existing setups.
> Unfortunately I did not have anough time to resolve the issues in time
> for 2.6.16 final and so I think it is the best to disable new code by
> default for now. I do not want to revert the changes completely as they
> are still useful.

Ah, okay.  Thank!  I need this patch on my server here!

Cheers