From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader.
Date: Wed, 4 Aug 2010 00:57:08 -0700 (PDT) [thread overview]
Message-ID: <441366.48179.qm@web37605.mail.mud.yahoo.com> (raw)
In-Reply-To: <1280847186-11501-3-git-send-email-maximlevitsky@gmail.com>
I see two immediate problems with this patch:
1. On cosmetic level, custom debug macros should not be employed. Device
core already have this functionality (dynamic debug levels and such). Please,
use dev_dbg and friends for print-outs.
2. On a structural level, I'd rather prefer host drivers to not start their
own threads. If you look at both current host implementations, they operate
in callback fashion. Apart from saving some resources, this reduces the
amount of problems encountered during suspend/resume and shutdown.
next prev parent reply other threads:[~2010-08-04 7:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 14:53 [PATCH 0/2] Driver for Ricoh cardreader Maxim Levitsky
2010-08-03 14:53 ` [PATCH 1/2] MEMSTICK: fix hangs on unexpected device removal in mspro_blk Maxim Levitsky
2010-08-04 7:50 ` Alex Dubov
2010-08-04 16:53 ` Maxim Levitsky
2010-08-04 21:41 ` Maxim Levitsky
2010-08-05 8:43 ` Alex Dubov
2010-08-05 17:48 ` Maxim Levitsky
2010-08-06 7:37 ` Alex Dubov
2010-08-03 14:53 ` [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-08-04 7:57 ` Alex Dubov [this message]
2010-08-04 16:48 ` Maxim Levitsky
2010-08-04 19:31 ` Maxim Levitsky
-- strict thread matches above, loose matches on Subject: below --
2010-08-05 8:30 Alex Dubov
2010-08-05 11:20 ` Maxim Levitsky
2010-08-05 11:48 ` Alex Dubov
2010-08-05 12:30 ` Maxim Levitsky
2010-08-05 17:47 ` Maxim Levitsky
2010-08-06 7:43 ` Alex Dubov
2010-08-06 10:56 ` Maxim Levitsky
2010-08-07 13:15 ` Alex Dubov
2010-08-07 15:58 ` Maxim Levitsky
2010-08-08 13:31 ` Alex Dubov
2010-08-06 8:01 ` Alex Dubov
2010-08-05 12:46 ` Maxim Levitsky
2010-08-06 7:59 ` Alex Dubov
2010-08-06 10:59 ` Maxim Levitsky
2010-08-07 13:12 ` Alex Dubov
2010-08-07 16:03 ` Maxim Levitsky
2010-08-08 13:33 ` Alex Dubov
2010-08-07 20:22 ` Maxim Levitsky
2010-08-08 14:26 ` Alex Dubov
2010-08-08 15:07 ` Maxim Levitsky
2010-08-08 20:08 ` Maxim Levitsky
2010-08-09 6:31 ` Alex Dubov
2010-08-09 6:56 ` Maxim Levitsky
2010-08-09 15:30 ` Maxim Levitsky
2010-08-10 8:12 ` Alex Dubov
2010-08-10 9:47 ` Maxim Levitsky
2010-08-11 8:08 ` Alex Dubov
2010-08-11 8:32 ` Maxim Levitsky
2010-08-12 7:22 ` Alex Dubov
2010-08-12 7:58 ` Maxim Levitsky
2010-08-09 19:19 ` Maxim Levitsky
2010-08-10 7:53 ` Alex Dubov
2010-08-10 9:50 ` Maxim Levitsky
2010-08-11 8:16 ` Alex Dubov
2010-12-09 2:39 MEMSTICK: Add my 2 drivers Maxim Levitsky
2010-12-09 2:42 ` [PATCH 2/2] memstick: Add driver for Ricoh R5C592 card reader Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441366.48179.qm@web37605.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox