From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbWCNHNM (ORCPT ); Tue, 14 Mar 2006 02:13:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752292AbWCNHNM (ORCPT ); Tue, 14 Mar 2006 02:13:12 -0500 Received: from mail.dvmed.net ([216.237.124.58]:36516 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1750887AbWCNHNL (ORCPT ); Tue, 14 Mar 2006 02:13:11 -0500 Message-ID: <44166D04.3070100@garzik.org> Date: Tue, 14 Mar 2006 02:13:08 -0500 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Morton CC: Ed Lin , linux-scsi@vger.kernel.org, promise_linux@promise.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver References: <20060313192042.56bf67b3.akpm@osdl.org> In-Reply-To: <20060313192042.56bf67b3.akpm@osdl.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > "Ed Lin" wrote: >>I guess DMA_32BIT_MASK is OK? > > > If that's semantically what the 0xffffffff means then yes. It means "select lower 32 bits, because the other 32 bits are elsewhere." Since its an arg to cpu_to_le32() I suppose there is an implicit truncation in there, but I add such masking myself to my own code. Makes it more clear to the reader what's going on, IMO. Its not quite what DMA_32BIT_MASK intends, either, IMO. Jeff