linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject_uevent CONFIG_SYSFS=n build fix
Date: Tue, 14 Mar 2006 20:03:39 -0500	[thread overview]
Message-ID: <441767EB.6070908@ce.jp.nec.com> (raw)
In-Reply-To: <20060315000951.GA6608@suse.de>

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi,

Greg KH wrote:
>>@@ -27,6 +27,8 @@
>> #include <asm/atomic.h>
>> 
>> #define KOBJ_NAME_LEN			20
>>+
>>+#ifdef CONFIG_HOTPLUG
>> #define UEVENT_HELPER_PATH_LEN		256

> That shouldn't be needed, right?

You're right. They are not needed.
Please disregard that part.

Thanks,
-- 
Jun'ichi Nomura, NEC Solutions (America), Inc.

[-- Attachment #2: kobject_uevent-config_sysfs_n-build-fix.patch --]
[-- Type: text/x-patch, Size: 952 bytes --]

--- linux-2.6.16-rc6-mm1.orig/lib/kobject_uevent.c	2006-03-14 22:57:23.000000000 +0900
+++ linux-2.6.16-rc6-mm1/lib/kobject_uevent.c	2006-03-15 08:39:33.000000000 +0900
@@ -25,6 +25,11 @@
 #define BUFFER_SIZE	2048	/* buffer for the variables */
 #define NUM_ENVP	32	/* number of env pointers */
 
+#ifdef CONFIG_HOTPLUG
+u64 uevent_seqnum;
+char uevent_helper[UEVENT_HELPER_PATH_LEN] = "/sbin/hotplug";
+#endif
+
 #if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)
 static DEFINE_SPINLOCK(sequence_lock);
 static struct sock *uevent_sock;
--- linux-2.6.16-rc6-mm1.orig/kernel/ksysfs.c	2006-03-14 22:57:31.000000000 +0900
+++ linux-2.6.16-rc6-mm1/kernel/ksysfs.c	2006-03-15 08:41:11.000000000 +0900
@@ -15,9 +15,6 @@
 #include <linux/module.h>
 #include <linux/init.h>
 
-u64 uevent_seqnum;
-char uevent_helper[UEVENT_HELPER_PATH_LEN] = "/sbin/hotplug";
-
 #define KERNEL_ATTR_RO(_name) \
 static struct subsys_attribute _name##_attr = __ATTR_RO(_name)

  reply	other threads:[~2006-03-15  1:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14 16:11 [PATCH] kobject_uevent CONFIG_SYSFS=n build fix Jun'ichi Nomura
2006-03-14 22:01 ` Greg KH
2006-03-15  0:00   ` Jun'ichi Nomura
2006-03-15  0:09     ` Greg KH
2006-03-15  1:03       ` Jun'ichi Nomura [this message]
2006-03-15  2:49         ` Greg KH
2006-03-15 13:28           ` Jun'ichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=441767EB.6070908@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).