From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: kamezawa.hiroyu@jp.fujitsu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu
Date: Thu, 16 Mar 2006 21:04:22 +1100 [thread overview]
Message-ID: <44193826.8010701@yahoo.com.au> (raw)
In-Reply-To: <20060316014820.51dbb3b8.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>for_each_cpu has always meant for
>> each possible CPU.
>
>
> That was the most long-winded ack I've ever seen ;)
>
Is not! :). This is the very reason why I think it is pointless churn.
There are plenty of functions (even static, confined to a single file,
or ones much more complex than this) which could unquestionably have
their names changed for the better.
This change doesn't even add anything except a redundant element so
it is even questionable that it makes the name better at all.
But I know you've got your heart set on them now so I won't continue
with the impossible task of talking you out of them ;) Just don't
expect that people will suddenly start getting hotplug-cpu races
right, overnight.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-16 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 3:21 [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu KAMEZAWA Hiroyuki
2006-03-16 3:40 ` Andrew Morton
2006-03-16 4:13 ` KAMEZAWA Hiroyuki
2006-03-16 3:43 ` Nick Piggin
2006-03-16 3:55 ` Andrew Morton
2006-03-16 4:08 ` Nick Piggin
2006-03-16 4:17 ` KAMEZAWA Hiroyuki
2006-03-16 4:24 ` Nick Piggin
2006-03-16 6:22 ` KAMEZAWA Hiroyuki
2006-03-16 6:49 ` Nick Piggin
2006-03-16 9:48 ` Andrew Morton
2006-03-16 10:04 ` Nick Piggin [this message]
2006-03-16 4:33 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44193826.8010701@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox