Re: Linux v2.6.16-rc6

Christoph Hellwig
2006-03-13T21:57:45Z

On Mon, Mar 13, 2006 at 12:54:53PM -0700, Bjorn Helgaas wrote:
> On Sunday 12 March 2006 02:03, Christoph Hellwig wrote:
> > On Sat, Mar 11, 2006 at 03:58:12PM -0800, Linus Torvalds wrote:
> > > Bjorn Helgaas:
> > > [IA64] don't report !sn2 or !summit hardware as an error
> > > [IA64] SGI SN drivers: don't report !sn2 hardware as an error
> >
> > These should be reverted. They return success from initcalls when they
> > should report failure. In the mmtimer case this is a real bug as it can
> > be modular, in others it's just cosmetic but provides people wrong examples
> > to cut & paste from.
>
> Do you want all the drivers that just return pci_register_driver(&foo)
> to be changed as well? I haven't heard a compelling argument either way,
> but there are certainly many drivers that return 0 when they successfully
> register a driver that didn't find any devices, e.g.,

That's different. The pci drivers support hotplug. The ia64-specific
drivers only driver onboard devices that can't appear at runtime.