From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Con Kolivas <kernel@kolivas.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
ck@vds.kolivas.org, Andreas Mohr <andi@rhlx01.fht-esslingen.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@suse.cz>, Stefan Seyfried <seife@suse.de>
Subject: Re: [PATCH][RFC] mm: swsusp shrink_all_memory tweaks
Date: Sat, 18 Mar 2006 15:41:18 +1100 [thread overview]
Message-ID: <441B8F6E.7010802@yahoo.com.au> (raw)
In-Reply-To: <200603181514.27455.kernel@kolivas.org>
Con Kolivas wrote:
> @@ -1567,7 +1546,7 @@ loop_again:
> zone->temp_priority = DEF_PRIORITY;
> }
>
> - for (priority = DEF_PRIORITY; priority >= 0; priority--) {
> + for_each_priority_reverse(priority) {
What's this for? The for loop is simple and easy to read, after
the change, you have to look somewhere else to see what it does.
> Index: linux-2.6.16-rc6-mm1/include/linux/swap.h
> ===================================================================
> --- linux-2.6.16-rc6-mm1.orig/include/linux/swap.h 2006-03-18 13:29:38.000000000 +1100
> +++ linux-2.6.16-rc6-mm1/include/linux/swap.h 2006-03-18 14:50:11.000000000 +1100
> @@ -66,6 +66,51 @@ typedef struct {
> unsigned long val;
> } swp_entry_t;
>
> +struct scan_control {
Why did you put this here? scan_control really can't go outside vmscan.c,
it is meant only to ease the passing of lots of parameters, and not as a
consistent interface.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-18 4:41 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 17:04 Faster resuming of suspend technology Jun OKAJIMA
2006-03-11 7:22 ` Nigel Cunningham
2006-03-11 12:17 ` Jun OKAJIMA
2006-03-11 12:46 ` Nigel Cunningham
2006-03-12 9:26 ` Jun OKAJIMA
2006-03-12 17:54 ` Jim Crilly
2006-03-12 23:06 ` Nigel Cunningham
2006-03-20 12:45 ` Jun OKAJIMA
2006-03-21 11:33 ` Fwd: " Jun OKAJIMA
2006-03-27 23:57 ` Jun OKAJIMA
2006-03-28 0:28 ` Nigel Cunningham
2006-03-28 12:48 ` [Xen-devel] " Keir Fraser
2006-03-12 21:32 ` Andreas Mohr
2006-03-12 22:30 ` [ck] " Con Kolivas
2006-03-13 1:43 ` Nigel Cunningham
2006-03-13 10:12 ` Pavel Machek
2006-03-13 11:10 ` Nigel Cunningham
2006-03-14 10:32 ` Pavel Machek
2006-03-13 10:06 ` Pavel Machek
2006-03-13 10:35 ` [ck] " Con Kolivas
2006-03-13 10:43 ` Pavel Machek
2006-03-13 11:13 ` Andreas Mohr
2006-03-13 11:36 ` does swsusp suck aftre resume for you? [was Re: [ck] Re: Faster resuming of suspend technology.] Pavel Machek
2006-03-13 12:03 ` does swsusp suck after resume for you? [was " Con Kolivas
2006-03-14 5:13 ` Con Kolivas
2006-03-14 8:24 ` Andreas Mohr
2006-03-14 11:51 ` Pavel Machek
2006-03-14 12:33 ` Con Kolivas
2006-03-14 12:43 ` Pavel Machek
2006-03-14 17:36 ` Lee Revell
2006-03-14 21:34 ` Con Kolivas
2006-03-14 18:06 ` Rafael J. Wysocki
2006-03-14 21:45 ` Con Kolivas
2006-03-15 10:37 ` does swsusp suck aftre resume for you? [was " Stefan Seyfried
2006-03-15 17:59 ` Pavel Machek
2006-03-15 21:32 ` Nigel Cunningham
2006-03-16 10:33 ` does swsusp suck after resume for you? Con Kolivas
2006-03-16 10:46 ` Pavel Machek
2006-03-16 10:47 ` Con Kolivas
2006-03-16 10:50 ` Pavel Machek
2006-03-16 21:33 ` Con Kolivas
2006-03-16 21:44 ` Pavel Machek
2006-03-16 22:15 ` Rafael J. Wysocki
2006-03-17 4:28 ` [PATCH] swsusp reclaim tweaks was: " Con Kolivas
2006-03-17 4:46 ` [ck] " Con Kolivas
2006-03-17 6:17 ` [PATCH] swsusp reclaim tweaks 2 Con Kolivas
2006-03-17 17:31 ` Rafael J. Wysocki
2006-03-18 4:14 ` [PATCH][RFC] mm: swsusp shrink_all_memory tweaks Con Kolivas
2006-03-18 4:41 ` Nick Piggin [this message]
2006-03-18 4:46 ` Con Kolivas
2006-03-18 4:52 ` Nick Piggin
2006-03-18 4:56 ` Con Kolivas
2006-03-18 5:44 ` Nick Piggin
2006-03-18 6:14 ` Con Kolivas
2006-03-18 8:30 ` Nick Piggin
2006-03-18 9:40 ` Con Kolivas
2006-03-16 10:55 ` [ck] Re: does swsusp suck after resume for you? Andreas Mohr
2006-03-17 5:23 ` 2.6.16-rc6: swsusp cannot find swap partition Mark Lord
2006-03-17 5:34 ` Mark Lord
2006-03-16 11:31 ` [ck] Re: does swsusp suck after resume for you? Con Kolivas
2006-03-16 2:20 ` swsusp_suspend continues? Con Kolivas
2006-03-16 9:19 ` Pavel Machek
2006-03-16 16:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441B8F6E.7010802@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=ck@vds.kolivas.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
--cc=seife@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox