From: Richard Knutsson <ricknu-0@student.ltu.se>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, aia21@cantab.net, len.brown@intel.com
Subject: Re: [patch 1/1] consolidate TRUE and FALSE
Date: Mon, 20 Mar 2006 15:46:41 +0100 [thread overview]
Message-ID: <441EC051.2050505@student.ltu.se> (raw)
In-Reply-To: <200603161004.k2GA46Fc029649@shell0.pdx.osdl.net>
Hi all
(and sorry Andrew for the double-mailing, hit the wrong button)
akpm@osdl.org wrote:
>diff -puN include/linux/kernel.h~consolidate-true-and-false include/linux/kernel.h
>--- devel/include/linux/kernel.h~consolidate-true-and-false 2006-03-16 02:01:02.000000000 -0800
>+++ devel-akpm/include/linux/kernel.h 2006-03-16 02:01:02.000000000 -0800
>@@ -18,6 +18,13 @@
>
> extern const char linux_banner[];
>
>+/*
>+ * Give these a funny-looking definition to improve the chances of them
>+ * clashing with other definitions of TRUE and FALSE, causing a cpp error
>+ */
>+#define TRUE ((1))
>+#define FALSE ((0))
>+
> #define INT_MAX ((int)(~0U>>1))
> #define INT_MIN (-INT_MAX - 1)
> #define UINT_MAX (~0U)
>
Just an alternative implementation, letting "true" be true and "false"
be false.
Also making it similar to GCC's library.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
diff -Narup a/include/linux/stdbool.h b/include/linux/stdbool.h
--- a/include/linux/stdbool.h 1970-01-01 01:00:00.000000000 +0100
+++ b/include/linux/stdbool.h 2006-03-20 04:15:47.000000000 +0100
@@ -0,0 +1,15 @@
+/**
+ * Boolean handling
+ */
+#ifndef _STDBOOL_H /* Same name as in GCC's include/stdbool.h */
+#define _STDBOOL_H
+
+typedef _Bool bool;
+
+#define true ((0==0))
+#define false ((!true))
+
+#define TRUE true
+#define FALSE false
+
+#endif
diff -Narup a/include/linux/types.h b/include/linux/types.h
--- a/include/linux/types.h 2006-03-19 23:47:06.000000000 +0100
+++ b/include/linux/types.h 2006-03-20 03:51:39.000000000 +0100
@@ -3,6 +3,7 @@
#ifdef __KERNEL__
#include <linux/config.h>
+#include <linux/stdbool.h>
#define BITS_TO_LONGS(bits) \
(((bits)+BITS_PER_LONG-1)/BITS_PER_LONG)
prev parent reply other threads:[~2006-03-20 14:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 10:01 [patch 1/1] consolidate TRUE and FALSE akpm
2006-03-16 10:28 ` Anton Altaparmakov
2006-03-16 10:42 ` Andrew Morton
2006-03-16 19:55 ` Nicholas Miell
2006-03-16 19:55 ` Jan Engelhardt
2006-03-16 10:36 ` Arjan van de Ven
2006-03-16 16:01 ` Christoph Hellwig
2006-03-16 16:29 ` Randy.Dunlap
2006-03-16 16:30 ` Christoph Hellwig
2006-03-16 16:36 ` Randy.Dunlap
2006-03-16 16:36 ` Christoph Hellwig
2006-03-16 16:42 ` Anton Altaparmakov
2006-03-16 16:50 ` Al Viro
[not found] ` <2c0942db0603160905v26011d8dx1e64967b2eb4deac@mail.gmail.com>
2006-03-16 17:11 ` Al Viro
2006-03-16 18:50 ` Anton Altaparmakov
2006-03-16 18:53 ` Anton Altaparmakov
2006-03-16 19:59 ` Jan Engelhardt
2006-03-16 22:35 ` Anton Altaparmakov
2006-03-16 16:42 ` Randy.Dunlap
2006-03-16 16:39 ` Anton Altaparmakov
2006-03-16 17:41 ` Sam Ravnborg
2006-03-16 18:00 ` Al Viro
2006-03-16 18:12 ` Randy.Dunlap
2006-03-16 18:49 ` Al Viro
2006-03-16 18:58 ` Randy.Dunlap
2006-03-16 18:52 ` Sam Ravnborg
2006-03-16 21:17 ` Valdis.Kletnieks
2006-03-16 21:28 ` Joshua Hudson
2006-03-16 23:53 ` David Wagner
2006-03-16 17:09 ` Xavier Bestel
2006-03-16 16:49 ` Al Viro
2006-03-16 21:26 ` Andrew Morton
2006-03-17 22:43 ` Xavier Bestel
2006-03-17 22:56 ` Andrew Morton
2006-03-18 21:57 ` Jan Engelhardt
2006-03-19 11:41 ` Xavier Bestel
2006-03-16 17:07 ` Greg KH
2006-03-16 17:13 ` Greg KH
2006-03-20 14:46 ` Richard Knutsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441EC051.2050505@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox