From: Phillip Susi <psusi@cfl.rr.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options
Date: Mon, 20 Mar 2006 11:25:26 -0500 [thread overview]
Message-ID: <441ED776.2000108@cfl.rr.com> (raw)
In-Reply-To: <20060319200424.5a3647aa.akpm@osdl.org>
Andrew Morton wrote:
> I didn't see that update, and I don't miss much.
>
See http://lkml.org/lkml/2006/3/5/171
> Please provide a description of this change. What problem is it fixing?
> How does it fix it? What are the consequences of not making this change?
In the initial patch I made a typo. As Pekka Enberg pointed out, with
the if still following the else, you can still get a null uid written to
the disk if you specify a default uid= without uid=forget. In other
words, if the desktop user is uid=1000 and the mount option uid=1000 is
given ( which is done on ubuntu automatically and probably other
distributions that use hal ), then if any other user besides uid 1000
owns a file then a 0 will be written to the media as the owning uid
instead. This is exactly what the original patch was trying to prevent.
next prev parent reply other threads:[~2006-03-20 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 2:32 [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options Phillip Susi
2006-03-20 4:04 ` Andrew Morton
2006-03-20 16:25 ` Phillip Susi [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-03-04 19:32 Phillip Susi
2006-03-05 19:22 ` Pekka Enberg
2006-03-06 1:10 ` Phillip Susi
2006-03-06 7:31 ` Pekka J Enberg
2006-03-07 3:23 ` Phillip Susi
2006-03-07 7:24 ` Pekka J Enberg
2006-03-07 15:49 ` Phillip Susi
2006-03-07 16:50 ` Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441ED776.2000108@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox