From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755674AbcCXLtC (ORCPT ); Thu, 24 Mar 2016 07:49:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:55329 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbcCXLsp convert rfc822-to-8bit (ORCPT ); Thu, 24 Mar 2016 07:48:45 -0400 From: Johannes Thumshirn To: linux-nvdimm@ml01.01.org Cc: Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/13] libnvdimm, blk: use devm_add_action to release bdev resources Date: Thu, 24 Mar 2016 12:48:43 +0100 Message-ID: <44211312.XSqkvMyyJm@c203> User-Agent: KMail/5.1.2 (Linux/4.5.0-1-default; KDE/5.20.0; x86_64; ; ) In-Reply-To: <20160324012547.21436.51123.stgit@dwillia2-desk3.jf.intel.com> References: <20160324012520.21436.22505.stgit@dwillia2-desk3.jf.intel.com> <20160324012547.21436.51123.stgit@dwillia2-desk3.jf.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mittwoch, 23. März 2016 18:25:47 CET Dan Williams wrote: > Register a callback to clean up the request_queue and put the gendisk at > driver disable time. > > Cc: Ross Zwisler > Signed-off-by: Dan Williams [...] > > static int nd_blk_remove(struct device *dev) > { > - struct nd_blk_device *blk_dev = dev_get_drvdata(dev); > - > if (is_nd_btt(dev)) > nvdimm_namespace_detach_btt(to_nd_btt(dev)); > - else > - nd_blk_detach_disk(blk_dev); > - kfree(blk_dev); > - > return 0; > } > Can't this be void? > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850