From: Zach Brown <zach.brown@oracle.com>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, stern@rowland.harvard.edu
Subject: Re: [patch] add private data to notifier_block
Date: Wed, 22 Mar 2006 10:00:34 -0800 [thread overview]
Message-ID: <442190C2.6040001@oracle.com> (raw)
In-Reply-To: <1142970154.31210.10.camel@whizzy>
Kristen Accardi wrote:
> device data can be easily accessed. This patch will modify the
> notifier_block struct to add a void *, and will require no modifications
> to any other users of the notifier_block.
> {
> int (*notifier_call)(struct notifier_block *self, unsigned long, void *);
> struct notifier_block *next;
> + void *data;
> int priority;
> };
Well, it might introduce warnings in users who weren't using named
initializers -- their bare priority initialization might now shift to
trying to initialize a pointer.
Though, that's probably a good thing as it gives an opportunity to
convert them. We also don't want to create a padded structure by
putting the void * after the int.
- z
next prev parent reply other threads:[~2006-03-22 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 19:42 [patch] add private data to notifier_block Kristen Accardi
2006-03-22 18:00 ` Zach Brown [this message]
2006-03-22 19:04 ` Alan Stern
2006-03-22 21:00 ` Kristen Accardi
2006-03-23 10:06 ` Jes Sorensen
2006-03-23 18:01 ` Kristen Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442190C2.6040001@oracle.com \
--to=zach.brown@oracle.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox