public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Nigel Cunningham <ncunningham@cyclades.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Pavel Machek <pavel@suse.cz>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] swsusp: separate swap-writing/reading code
Date: Thu, 23 Mar 2006 17:48:58 -0500	[thread overview]
Message-ID: <442325DA.80300@rtr.ca> (raw)
In-Reply-To: <200603232253.01025.rjw@sisk.pl>

Rafael J. Wysocki wrote:
>
> I agree it probably may be improved.  Still it seems to be good enough.  Further,
> it's more efficient than the previous solution, so I consider it as an improvement.
> Also this code has been tested for quite some time in -mm and appears to
> behave properly, at least we haven't got any bug reports related to it so far.

I find the in-kernel swsusp to be quite slow, and it seems to use
an awful lot of memory for book-keeping.  So count that as encouragement
to improve the performance when you can.

> Currently I'm not working on any better solution.  If you can provide any
> patches to implement one, please submit them, but I think they'll have to be
> tested for as long as this code, in -mm.

It would be *really nice* if you guys could stop being so underhandedly
nasty in every single reply to anything from Nigel.

He really is trying to help, you know.

Cheers

  reply	other threads:[~2006-03-23 22:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200603231702.k2NH2OSC006774@hera.kernel.org>
2006-03-23 21:13 ` [PATCH] swsusp: separate swap-writing/reading code Nigel Cunningham
2006-03-23 21:53   ` Rafael J. Wysocki
2006-03-23 22:48     ` Mark Lord [this message]
2006-03-23 23:39       ` Rafael J. Wysocki
2006-03-27 10:26       ` Pavel Machek
2006-03-27 10:43         ` Nigel Cunningham
2006-03-27 23:15           ` regular swsusp flamewar [was Re: [PATCH] swsusp: separate swap-writing/reading code] Pavel Machek
2006-03-27 23:36             ` Nigel Cunningham
2006-03-28  1:18               ` regular swsusp flamewar Harald Arnesen
2006-03-28  9:15               ` regular swsusp flamewar [was Re: [PATCH] swsusp: separate swap-writing/reading code] Pavel Machek
2006-03-28  9:16               ` Pavel Machek
2006-03-28 10:28                 ` Nigel Cunningham
2006-03-28  1:16             ` regular swsusp flamewar Harald Arnesen
2006-03-28  9:13               ` Pavel Machek
2006-03-23 23:58     ` [PATCH] swsusp: separate swap-writing/reading code Andrew Morton
2006-03-24  0:32       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442325DA.80300@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@cyclades.com \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox