From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752825AbcGMIdW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 04:33:22 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:50265 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751345AbcGMIdT convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 04:33:19 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org, Alexander Shiyan <shc_work@mail.ru>
Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI
Date: Wed, 13 Jul 2016 10:32:30 +0200
Message-ID: <4424049.9GWmiGNCEh@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1468398000.319627182@f165.i.mail.ru>
References: <20160707094952.4111577-1-arnd@arndb.de> <9132787.CoNHcRuYpT@wuerfel> <1468398000.319627182@f165.i.mail.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K0:/J7ehZP62ImMH0wjfuAO6a26T8iq8PQU1b6U9Vc+tMpmp8xeImT
 YGris4P5swSiKaL6dU+jcPrvZcLFeQLMZUVGR8G5T6JdU3e1MlgjdwHj3T/VkqpkL1l1O7d
 XKqE9uv4NukGgjQmQBgZ5vNOtTd8lOh8Ew+z+SwiVgQleSehF0l+Q6kTeaxCFZj1uBA+zCi
 ZCiZtVrF2NT8KMMKj8P3A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:PXPWbUovcCM=:BugwsitE1BcUDhwBMDAowK
 sJzfSTJUnDtEOT1S/hPSJR4LWh9vmlX3gxXnq9bIAYwJo8jdHkTYXVG/4o46dC04qKZbjuwEJ
 cr4ahNVwzWb366XO/oODKBxhdO12VdHX7wg1pY4H2bVupbe19ZBRVFZEhqHOzhOBRcYM3cBb2
 9EWR1SLNabOubWFkysKWyeL+92XyWo6XuNp8oZNP+YqsItYLSKkj5SWGkSOeNguEtWGpqlgJx
 AM4/jC0nXtalC4yJMWptqV/sbeUA7qTzH0fFq/xb/kVRUF34nyR0x4BCsJqXVvOIPiPGtjMRC
 HclT5RcPcgMs7rybEMd2v2hpqP5MihQ2BYAfCzVkoRkwGfOxzdlATq/9znzoILMgqH0+xpx8g
 7kTL+CxKGTRIsYAxx3u3EedSjSlMlPX0zO6ZnchzjeCYSOA9M7MaAreixoTlEQY9vjcvHfb6Q
 +tUJjEGess2OnuDtvcn6UOVXvQpAOZrjMJhX7t48fLGZTVrPkv5Nu3DBH+3ejP6TKZHZ4MUdK
 c59/r28gXFzOijsFnj5Dr3HdAcwyPuXLj3EeGJnZtXXnozxN1ZIkvX1Cmf1yoLOYm1TTZMzan
 CrzkPfy7Odu4hYPcJlC7ZTlXXMhBDuegFpZXw5+rEZzufVfhkATE7PGDg1GpB1S1/X+nUWrUG
 FwXyFmhdmd9mjn1ocnXNvHVY+3dsTuDV+qTwx/WvUYe+R8UjWwU1HNWqdjcHl8mdyXFYJC9bz
 +dlNfEz4ImZtYlFV
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, July 13, 2016 11:20:00 AM CEST Alexander Shiyan wrote:
> >Среда, 13 июля 2016, 11:13 +03:00 от Arnd Bergmann <arnd@arndb.de>:
> >
> >On Tuesday, July 12, 2016 3:49:47 PM CEST Rob Herring wrote:
> >> On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
> >> > +
> >> > +An additional register is present in the system controller,
> >> > +which is assumed to be in the same device tree, with and marked
> >> > +as compatible with "cirrus,ep7209-syscon3".
> >> > +
> >> > +Example:
> >> > +
> >> > +spi@80000500 {
> >> > +     #address-cells = <1>;
> >> > +     #size-cells = <0>;
> >> > +     compatible = "cirrus,ep7209-spi";
> >> > +     reg = <0x80000500 0x4>;
> >> > +     interrupts = <15>;
> >> > +     clocks = <&clks CLPS711X_CLK_SPI>;
> >> > +     status = "disabled";
> >> > +};
> >> > +
> >> > +syscon3: syscon@80002200 {
> >> 
> >> This looks like it shouldn't be here.
> >
> >The label, or the entire node?
> 
> I think that the whole syscon3 node is redundant.

The node is needed here because it is required for the device to
work: the binding doesn't contain a label for the syscon reference
but as I documented above, any driver will have to look up the
syscon by compatible string.

	Arnd