From: Arjan van de Ven <arjan@linux.intel.com>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Andi Kleen <ak@suse.de>, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table
Date: Fri, 24 Mar 2006 16:48:48 +0100 [thread overview]
Message-ID: <442414E0.4050806@linux.intel.com> (raw)
In-Reply-To: <20060324074808.A14035@unix-os.sc.intel.com>
Ashok Raj wrote:
> On Fri, Mar 24, 2006 at 04:42:17PM +0100, Arjan van de Ven wrote:
>> Andi Kleen wrote:
>>> In theory they should be the same. What do you think is different?
>> in practice the x86-64 version returns "success" if there is one byte in the entire
>> memory range that complies with the requested type, even if the rest of the range is
>> of another type. What the ideal is for the purpose here is "is the entire range reserved",
>> but for now I'll settle for "is the start address reserved".
>>
>> (and yes you can express the "is the start address reserved" as a question to the current function for
>> a 1 byte range, I probably should do that I suppose)
>
> or why not check
>
> if (type == ei->type && start >= ei->addr && end <= (ei->addr + ei->size))
> return 1;
>
> will this make the range check check stricter?
that's not going to cut it; you can have 2 e820 entries that together span the range
next prev parent reply other threads:[~2006-03-24 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 18:22 [patch] Ignore MCFG if the mmconfig area isn't reserved in the e820 table Arjan van de Ven
2006-03-23 17:56 ` Andi Kleen
2006-03-23 19:02 ` Arjan van de Ven
2006-03-23 19:15 ` Arjan van de Ven
2006-03-24 12:19 ` Andi Kleen
2006-03-24 13:36 ` Arjan van de Ven
2006-03-24 21:25 ` Greg KH
2006-03-24 15:22 ` [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table Ashok Raj
2006-03-24 15:24 ` Arjan van de Ven
2006-03-24 15:39 ` Andi Kleen
2006-03-24 15:42 ` Arjan van de Ven
2006-03-24 15:48 ` Ashok Raj
2006-03-24 15:48 ` Arjan van de Ven [this message]
2006-03-24 15:48 ` Andi Kleen
2006-03-24 15:50 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442414E0.4050806@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox