From: Arjan van de Ven <arjan@linux.intel.com>
To: Andi Kleen <ak@suse.de>
Cc: Ashok Raj <ashok.raj@intel.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table
Date: Fri, 24 Mar 2006 16:50:42 +0100 [thread overview]
Message-ID: <44241552.5020503@linux.intel.com> (raw)
In-Reply-To: <200603241648.19901.ak@suse.de>
Andi Kleen wrote:
> On Friday 24 March 2006 16:42, Arjan van de Ven wrote:
>> Andi Kleen wrote:
>>> In theory they should be the same. What do you think is different?
>> in practice the x86-64 version returns "success" if there is one byte in the entire
>> memory range that complies with the requested type, even if the rest of the range is
>> of another type.
>
> I would consider that a bug. Please send fix.
I'm less sure. It's what the function does, and I can see very valid usage models for it;
to detect that a certain type is NOT present. And the code is clearly written with that goal
in mind at least. I'm tempted to write a real range function but I also was hoping to avoid
doing that, since for the MCFG test it really is a bit overkill.
prev parent reply other threads:[~2006-03-24 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-23 18:22 [patch] Ignore MCFG if the mmconfig area isn't reserved in the e820 table Arjan van de Ven
2006-03-23 17:56 ` Andi Kleen
2006-03-23 19:02 ` Arjan van de Ven
2006-03-23 19:15 ` Arjan van de Ven
2006-03-24 12:19 ` Andi Kleen
2006-03-24 13:36 ` Arjan van de Ven
2006-03-24 21:25 ` Greg KH
2006-03-24 15:22 ` [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table Ashok Raj
2006-03-24 15:24 ` Arjan van de Ven
2006-03-24 15:39 ` Andi Kleen
2006-03-24 15:42 ` Arjan van de Ven
2006-03-24 15:48 ` Ashok Raj
2006-03-24 15:48 ` Arjan van de Ven
2006-03-24 15:48 ` Andi Kleen
2006-03-24 15:50 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44241552.5020503@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox