From: kernel test robot <yujie.liu@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <kbuild-all@lists.01.org>, <devel@driverdev.osuosl.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: [driver-core:debugfs_cleanup 1/1] fs/d_path.c:20:20: warning: Unsigned variable '.' can't be negative so it is unnecessary to test it. [unsignedPositive]
Date: Mon, 15 Nov 2021 17:22:33 +0800 [thread overview]
Message-ID: <4426183d-27e2-e900-480d-210e649441a1@intel.com> (raw)
In-Reply-To: <202111150057.2Z3oqaBC-lkp@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d
commit: 8247270bcf99bc7bf661ae2a3f2ee6e64c7f957d [1/1] fs: make d_path-like functions all have unsigned size
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> fs/d_path.c:20:20: warning: Unsigned variable '.' can't be negative so it is unnecessary to test it. [unsignedPositive]
if (likely(p->len >= 0))
^
vim +20 fs/d_path.c
7a5cf791a74764 Al Viro 2018-03-05 10
ad08ae586586ea Al Viro 2021-05-12 11 struct prepend_buffer {
ad08ae586586ea Al Viro 2021-05-12 12 char *buf;
8247270bcf99bc Greg Kroah-Hartman 2021-07-27 13 unsigned int len;
ad08ae586586ea Al Viro 2021-05-12 14 };
ad08ae586586ea Al Viro 2021-05-12 15 #define DECLARE_BUFFER(__name, __buf, __len) \
ad08ae586586ea Al Viro 2021-05-12 16 struct prepend_buffer __name = {.buf = __buf + __len, .len = __len}
ad08ae586586ea Al Viro 2021-05-12 17
ad08ae586586ea Al Viro 2021-05-12 18 static char *extract_string(struct prepend_buffer *p)
7a5cf791a74764 Al Viro 2018-03-05 19 {
ad08ae586586ea Al Viro 2021-05-12 @20 if (likely(p->len >= 0))
ad08ae586586ea Al Viro 2021-05-12 21 return p->buf;
ad08ae586586ea Al Viro 2021-05-12 22 return ERR_PTR(-ENAMETOOLONG);
ad08ae586586ea Al Viro 2021-05-12 23 }
ad08ae586586ea Al Viro 2021-05-12 24
:::::: The code at line 20 was first introduced by commit
:::::: ad08ae586586ea9e2c0228a3d5a083500ea54202 d_path: introduce struct prepend_buffer
:::::: TO: Al Viro <viro@zeniv.linux.org.uk>
:::::: CC: Al Viro <viro@zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
parent reply other threads:[~2021-11-15 9:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <202111150057.2Z3oqaBC-lkp@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4426183d-27e2-e900-480d-210e649441a1@intel.com \
--to=yujie.liu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox