From: Rene Herman <rene.herman@keyaccess.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: gregkh@suse.de, tiwai@suse.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: bus_add_device() losing an error return from the probe() method
Date: Mon, 27 Mar 2006 00:30:19 +0200 [thread overview]
Message-ID: <442715FB.7060404@keyaccess.nl> (raw)
In-Reply-To: <20060325175322.1e04852b.akpm@osdl.org>
Andrew Morton wrote:
> Looks sane, but please don't sprinkle `return' statements all over a
> function in this manner.
I actually prefer the multiple returns. You then don't have to "visually
scroll down" to the label to see what would happen when reading the
code. Even when there's common code before the return, I've never seen
GCC not optimise that to the goto form itself. You obviously the boss
though.
> It's a little surprising that this function returns "OK" if bus==NULL.
>
> Note that sysfs_create_link() can fail too. This was one optimistic
> function.
I assume that Greg hasn't commented yet since he's busy rewriting it
all, so that'll be okay :-)
Rene.
next prev parent reply other threads:[~2006-03-26 22:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:32 bus_add_device() losing an error return from the probe() method Rene Herman
2006-03-26 1:53 ` Andrew Morton
2006-03-26 22:30 ` Rene Herman [this message]
2006-04-04 19:10 ` patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree gregkh
2006-04-04 20:23 ` Dmitry Torokhov
2006-04-04 21:00 ` Greg KH
2006-04-04 21:15 ` Greg KH
2006-04-04 21:22 ` Andrew Morton
2006-04-04 21:28 ` Dmitry Torokhov
2006-04-04 21:45 ` Greg KH
2006-04-05 1:35 ` Dmitry Torokhov
2006-04-05 7:36 ` Russell King
2006-04-06 1:05 ` Greg KH
2006-04-05 1:59 ` Dmitry Torokhov
2006-04-04 22:12 ` Rene Herman
2006-04-05 0:23 ` Rene Herman
2006-04-05 1:45 ` Dmitry Torokhov
2006-04-05 18:36 ` Rene Herman
2006-04-05 18:44 ` Dmitry Torokhov
2006-04-05 1:48 ` Dmitry Torokhov
2006-04-05 13:50 ` Rene Herman
2006-04-05 14:59 ` Dmitry Torokhov
2006-04-05 21:22 ` Rene Herman
2006-04-05 13:55 ` Rene Herman
[not found] <5TNbU-7Xn-17@gated-at.bofh.it>
[not found] ` <5UsI5-Wf-9@gated-at.bofh.it>
[not found] ` <5UM40-3Dy-9@gated-at.bofh.it>
2006-03-27 13:41 ` bus_add_device() losing an error return from the probe() method Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442715FB.7060404@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).