From: Nick Piggin <nickpiggin@yahoo.com.au>
To: vatsa@in.ibm.com
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
suresh.b.siddha@intel.com, Dinakar Guniguntala <dino@in.ibm.com>,
pj@sgi.com, hawkes@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.16-mm2 4/4] sched_domain: Allocate sched_group structures dynamically
Date: Sun, 02 Apr 2006 15:21:21 +1000 [thread overview]
Message-ID: <442F5F51.3030104@yahoo.com.au> (raw)
In-Reply-To: <20060402050400.GA13423@in.ibm.com>
Srivatsa Vaddagiri wrote:
> On Sun, Apr 02, 2006 at 11:39:30AM +1000, Nick Piggin wrote:
>
>>Srivatsa Vaddagiri wrote:
>>
>>>+ if (!sched_group_phys) {
>>>+ sched_group_phys
>>>+ = kmalloc(sizeof(struct sched_group) *
>>>NR_CPUS,
>>>+ GFP_KERNEL);
>>>+ if (!sched_group_phys) {
>>>+ printk (KERN_WARNING "Can not alloc phys
>>>sched"
>>>+ "group\n");
>>>+ goto error;
>>>+ }
>>>+ sched_group_phys_bycpu[i] = sched_group_phys;
>>>+ }
>>
>>Doesn't the last assignment have to be outside the if statement?
>
>
> I dont think so. The assignment can happen once (when we allocate
> successfully) and not every time in the for loop?
>
Then after you have allocated sched_group_phys, subsequent cpus
in cpu_map will have their sched_group_phys_bycpu[] entry
uninitialised, by the looks?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-04-02 8:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 18:56 [PATCH 2.6.16-mm2 4/4] sched_domain: Allocate sched_group structures dynamically Srivatsa Vaddagiri
2006-04-02 1:39 ` Nick Piggin
2006-04-02 5:04 ` Srivatsa Vaddagiri
2006-04-02 5:21 ` Nick Piggin [this message]
2006-04-02 9:14 ` Srivatsa Vaddagiri
2006-04-02 7:35 ` Siddha, Suresh B
2006-04-02 9:17 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442F5F51.3030104@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=hawkes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox