From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: vatsa@in.ibm.com, mingo@elte.hu, suresh.b.siddha@intel.com,
dino@in.ibm.com, pj@sgi.com, hawkes@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.16-mm2 1/4] sched_domain - handle kmalloc failure
Date: Sun, 02 Apr 2006 15:37:11 +1000 [thread overview]
Message-ID: <442F6307.7040602@yahoo.com.au> (raw)
In-Reply-To: <20060401212533.61a02f9d.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>>In that case, would it be simpler just
>>to add a __GFP_NOFAIL here and forget about it?
>
>
> No new __GFP_NOFAILs, please.
It isn't a new one as such. It would simply make explicit the fact
that this code really can't handle allocation failures, and it is
presently depending on the allocator implementation to work.
> The fact that the CPU addition will succeed, but it'll run forever more
> with load balancing disabled still seems Just Wrong to me. We should
> either completely succeed or completely fail.
>
Yes. But we shouldn't partially fail and leave the machine crippled.
Hence, __GFP_NOFAIL as a good marker for someone who gets keen and
comes along to fix it up properly. If it were trivial to fix it, I
wouldn't suggest adding the __GFP_NOFAIL.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
prev parent reply other threads:[~2006-04-02 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 18:52 [PATCH 2.6.16-mm2 1/4] sched_domain - handle kmalloc failure Srivatsa Vaddagiri
2006-04-02 1:35 ` Nick Piggin
2006-04-02 5:25 ` Andrew Morton
2006-04-02 5:37 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442F6307.7040602@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=hawkes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox