* [PATCH 2/4] UEAGLE : support geode
@ 2006-04-02 16:39 matthieu castet
2006-04-02 16:44 ` matthieu castet
0 siblings, 1 reply; 2+ messages in thread
From: matthieu castet @ 2006-04-02 16:39 UTC (permalink / raw)
To: greg; +Cc: linux-kernel, usbatm, linux-usb-devel, ueagle
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
Hi,
this patch :
- increase ack timeout for slow system (geode 233MHz where HZ=100)
- reset the cmv ack flag when rebooting
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
[-- Attachment #2: ueagle2.patch --]
[-- Type: text/plain, Size: 989 bytes --]
Index: ueagle-atm.c
===================================================================
--- ueagle-atm.c (révision 264)
+++ ueagle-atm.c (révision 265)
@@ -243,7 +243,7 @@
#define BULK_TIMEOUT 300
#define CTRL_TIMEOUT 1000
-#define ACK_TIMEOUT msecs_to_jiffies(1500)
+#define ACK_TIMEOUT msecs_to_jiffies(3000)
#define UEA_INTR_IFACE_NO 0
#define UEA_US_IFACE_NO 1
@@ -1079,7 +1079,13 @@
uea_enters(INS_TO_USBDEV(sc));
uea_info(INS_TO_USBDEV(sc), "(re)booting started\n");
+ /* mask interrupt */
sc->booting = 1;
+ /* We need to set this here because, a ack timeout could have occured,
+ * but before we start the reboot, the ack occurs and set this to 1.
+ * So we will failed to wait Ready CMV.
+ */
+ sc->cmv_ack = 0;
UPDATE_ATM_STAT(signal, ATM_PHY_SIG_LOST);
/* reset statistics */
@@ -1105,6 +1111,7 @@
msleep(1000);
sc->cmv_function = MAKEFUNCTION(ADSLDIRECTIVE, MODEMREADY);
+ /* demask interrupt */
sc->booting = 0;
/* start loading DSP */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/4] UEAGLE : support geode
2006-04-02 16:39 [PATCH 2/4] UEAGLE : support geode matthieu castet
@ 2006-04-02 16:44 ` matthieu castet
0 siblings, 0 replies; 2+ messages in thread
From: matthieu castet @ 2006-04-02 16:44 UTC (permalink / raw)
To: greg; +Cc: linux-kernel, usbatm, linux-usb-devel, ueagle
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
matthieu castet wrote:
> Hi,
>
> this patch :
> - increase ack timeout for slow system (geode 233MHz where HZ=100)
> - reset the cmv ack flag when rebooting
>
add correct path for the file name
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
[-- Attachment #2: ueagle2.patch --]
[-- Type: text/plain, Size: 1051 bytes --]
Index: ueagle-atm.c
===================================================================
--- linux-2.6.15.old/drivers/usb/atm/ueagle-atm.c (révision 264)
+++ linux-2.6.15/drivers/usb/atm/ueagle-atm.c (révision 265)
@@ -243,7 +243,7 @@
#define BULK_TIMEOUT 300
#define CTRL_TIMEOUT 1000
-#define ACK_TIMEOUT msecs_to_jiffies(1500)
+#define ACK_TIMEOUT msecs_to_jiffies(3000)
#define UEA_INTR_IFACE_NO 0
#define UEA_US_IFACE_NO 1
@@ -1079,7 +1079,13 @@
uea_enters(INS_TO_USBDEV(sc));
uea_info(INS_TO_USBDEV(sc), "(re)booting started\n");
+ /* mask interrupt */
sc->booting = 1;
+ /* We need to set this here because, a ack timeout could have occured,
+ * but before we start the reboot, the ack occurs and set this to 1.
+ * So we will failed to wait Ready CMV.
+ */
+ sc->cmv_ack = 0;
UPDATE_ATM_STAT(signal, ATM_PHY_SIG_LOST);
/* reset statistics */
@@ -1105,6 +1111,7 @@
msleep(1000);
sc->cmv_function = MAKEFUNCTION(ADSLDIRECTIVE, MODEMREADY);
+ /* demask interrupt */
sc->booting = 0;
/* start loading DSP */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-02 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-02 16:39 [PATCH 2/4] UEAGLE : support geode matthieu castet
2006-04-02 16:44 ` matthieu castet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox