From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix unneeded rebuilds in drivers/media/video after moving source tree
Date: Tue, 04 Apr 2006 00:35:36 +0200 [thread overview]
Message-ID: <4431A338.3000709@gmx.net> (raw)
In-Reply-To: <20060331152226.GB8992@mars.ravnborg.org>
Sam Ravnborg schrieb:
>On Thu, Mar 30, 2006 at 10:49:45PM +0200, Carl-Daniel Hailfinger wrote:
>
>
>
>>Well, it would cause less confusion. It seems that ~90% of rebuilt files
>>are due to the following makefiles where full paths to includes are
>>specified:
>>./drivers/media/video/cx88/Makefile
>>./drivers/media/video/Makefile
>>./drivers/media/video/cx25840/Makefile
>>./drivers/media/video/saa7134/Makefile
>>./drivers/media/video/em28xx/Makefile
>>
>>Any objections to fix these?
>>
>>
>
>Care to send a path - then I will include it with next kbuild update.
>
>
This fixes some uneeded rebuilds under drivers/media/video after moving
the source tree. The makefiles used $(src) and $(srctree) for include
paths, which is unnecessary. Changed to use relative paths.
Compile tested, produces byte-identical code to the previous makefiles.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
--
http://www.hailfinger.org/
--- linux-2.6.16/drivers/media/video/cx25840/Makefile 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16-fixed/drivers/media/video/cx25840/Makefile 2006-04-04 00:07:01.000000000 +0200
@@ -3,4 +3,4 @@
obj-$(CONFIG_VIDEO_DECODER) += cx25840.o
-EXTRA_CFLAGS += -I$(src)/..
+EXTRA_CFLAGS += -Idrivers/media/video
--- linux-2.6.16/drivers/media/video/cx88/Makefile 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16-fixed/drivers/media/video/cx88/Makefile 2006-04-04 00:05:04.000000000 +0200
@@ -8,9 +8,9 @@
obj-$(CONFIG_VIDEO_CX88_ALSA) += cx88-alsa.o
obj-$(CONFIG_VIDEO_CX88_VP3054) += cx88-vp3054-i2c.o
-EXTRA_CFLAGS += -I$(src)/..
-EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/frontends
+EXTRA_CFLAGS += -Idrivers/media/video
+EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
+EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
extra-cflags-$(CONFIG_VIDEO_BUF_DVB) += -DHAVE_VIDEO_BUF_DVB=1
extra-cflags-$(CONFIG_DVB_CX22702) += -DHAVE_CX22702=1
--- linux-2.6.16/drivers/media/video/em28xx/Makefile 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16-fixed/drivers/media/video/em28xx/Makefile 2006-04-04 00:07:40.000000000 +0200
@@ -3,4 +3,4 @@
obj-$(CONFIG_VIDEO_EM28XX) += em28xx.o
-EXTRA_CFLAGS += -I$(src)/..
+EXTRA_CFLAGS += -Idrivers/media/video
--- linux-2.6.16/drivers/media/video/Makefile 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16-fixed/drivers/media/video/Makefile 2006-04-04 00:00:19.000000000 +0200
@@ -63,4 +63,4 @@
obj-$(CONFIG_VIDEO_DECODER) += saa7115.o cx25840/ saa7127.o
-EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
+EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
--- linux-2.6.16/drivers/media/video/saa7134/Makefile 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.16-fixed/drivers/media/video/saa7134/Makefile 2006-04-04 00:07:20.000000000 +0200
@@ -11,9 +11,9 @@
obj-$(CONFIG_VIDEO_SAA7134_DVB) += saa7134-dvb.o
-EXTRA_CFLAGS += -I$(src)/..
-EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/dvb-core
-EXTRA_CFLAGS += -I$(srctree)/drivers/media/dvb/frontends
+EXTRA_CFLAGS += -Idrivers/media/video
+EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
+EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
extra-cflags-$(CONFIG_VIDEO_BUF_DVB) += -DHAVE_VIDEO_BUF_DVB=1
extra-cflags-$(CONFIG_DVB_MT352) += -DHAVE_MT352=1
next prev parent reply other threads:[~2006-04-03 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 11:55 Spurious rebuilds of raid6 and drivers/media/video in 2.6.16 Carl-Daniel Hailfinger
2006-03-30 20:22 ` Sam Ravnborg
2006-03-30 20:49 ` Carl-Daniel Hailfinger
2006-03-31 15:22 ` Sam Ravnborg
2006-04-03 22:35 ` Carl-Daniel Hailfinger [this message]
2006-04-03 23:02 ` [PATCH] Fix unneeded rebuilds in drivers/net/chelsio after moving source tree Carl-Daniel Hailfinger
2006-04-04 15:02 ` [PATCH] Fix unneeded rebuilds in drivers/media/video " Sam Ravnborg
2006-04-05 23:32 ` Carl-Daniel Hailfinger
2006-04-06 6:31 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4431A338.3000709@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox