public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix unneeded rebuilds in drivers/media/video after moving source tree
Date: Thu, 06 Apr 2006 01:32:33 +0200	[thread overview]
Message-ID: <44345391.4000704@gmx.net> (raw)
In-Reply-To: <20060404150233.GA10608@mars.ravnborg.org>

Sam Ravnborg schrieb:
>>This fixes some uneeded rebuilds under drivers/media/video after moving
>>the source tree. The makefiles used $(src) and $(srctree) for include
>>paths, which is unnecessary. Changed to use relative paths.
>>
>>Compile tested, produces byte-identical code to the previous makefiles.
> 
> 
> Thanks, applied both.
> Did similar changes in bt8xx + some ppc code.

Thanks. Was it intentional to leave the line below in
drivers/media/video/bt8xx/Makefile?

EXTRA_CFLAGS += -I$(src)/..

I think it could be replaced with

EXTRA_CFLAGS += -Idrivers/media/video

but I'm not a kbuild expert.


Regards,
Carl-Daniel
-- 
http://www.hailfinger.org/

  reply	other threads:[~2006-04-05 23:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-30 11:55 Spurious rebuilds of raid6 and drivers/media/video in 2.6.16 Carl-Daniel Hailfinger
2006-03-30 20:22 ` Sam Ravnborg
2006-03-30 20:49   ` Carl-Daniel Hailfinger
2006-03-31 15:22     ` Sam Ravnborg
2006-04-03 22:35       ` [PATCH] Fix unneeded rebuilds in drivers/media/video after moving source tree Carl-Daniel Hailfinger
2006-04-03 23:02         ` [PATCH] Fix unneeded rebuilds in drivers/net/chelsio " Carl-Daniel Hailfinger
2006-04-04 15:02         ` [PATCH] Fix unneeded rebuilds in drivers/media/video " Sam Ravnborg
2006-04-05 23:32           ` Carl-Daniel Hailfinger [this message]
2006-04-06  6:31             ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44345391.4000704@gmx.net \
    --to=c-d.hailfinger.devel.2006@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox