From: Hannes Reinecke <hare@suse.de>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
Denis Vlasenko <vda@ilport.com.ua>,
SCSI List <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org, gibbs@scsiguy.com
Subject: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
Date: Mon, 10 Apr 2006 12:00:59 +0200 [thread overview]
Message-ID: <443A2CDB.5060404@suse.de> (raw)
In-Reply-To: <443A2805.6000806@s5r6.in-berlin.de>
Stefan Richter wrote:
> Rolf Eike Beer wrote:
>> Denis Vlasenko wrote:
>>> I am leaving it up to maintainer to decide. After all, the driver
>>> is for multiple OSes, other OS may lack mdelay().
>> The comment says about multiple milliseconds sleeps which just don't happen.
>
> Given what ah{c,d}_delay are (OS dependent wrappers) and how they are
> used (definitely not for multi-msec delays), they should just be changed
> into a #define ah{c,d}_delay(us) udelay(us) or into void inline
> ah{c,d}_delay(long us) {udelay(us);}.
I'd rather do a #define. Inlining simple functions is quite unneccessary
here.
Re multiplatform development: aic7{9,x}xx have ceased to be
multiplatfrom since the integration of scsi_transport_spi.
So I wouldn't worry too much about it.
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
next prev parent reply other threads:[~2006-04-10 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 5:44 [PATCH] deinline some functions in aic7xxx drivers, save 80k of text Denis Vlasenko
2006-04-10 5:46 ` Denis Vlasenko
2006-04-10 5:49 ` Denis Vlasenko
[not found] ` <200604100903.35431.eike-kernel@sf-tec.de>
[not found] ` <200604101015.36869.vda@ilport.com.ua>
2006-04-10 7:19 ` Rolf Eike Beer
2006-04-10 7:54 ` Denis Vlasenko
2006-04-10 9:40 ` Stefan Richter
2006-04-10 10:00 ` Hannes Reinecke [this message]
2006-04-10 10:16 ` Stefan Richter
2006-04-10 16:20 ` Arjan van de Ven
2006-04-10 8:43 ` Stefan Richter
2006-04-10 8:56 ` Denis Vlasenko
2006-04-10 10:19 ` Stefan Richter
2006-04-10 14:22 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443A2CDB.5060404@suse.de \
--to=hare@suse.de \
--cc=eike-kernel@sf-tec.de \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox