From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751114AbWDJKBN (ORCPT ); Mon, 10 Apr 2006 06:01:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751112AbWDJKBN (ORCPT ); Mon, 10 Apr 2006 06:01:13 -0400 Received: from cantor.suse.de ([195.135.220.2]:7133 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751111AbWDJKBM (ORCPT ); Mon, 10 Apr 2006 06:01:12 -0400 Message-ID: <443A2CDB.5060404@suse.de> Date: Mon, 10 Apr 2006 12:00:59 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.11) Gecko/20050727 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Stefan Richter Cc: Rolf Eike Beer , Denis Vlasenko , SCSI List , linux-kernel@vger.kernel.org, gibbs@scsiguy.com Subject: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text References: <200604100844.12151.vda@ilport.com.ua> <200604100903.35431.eike-kernel@sf-tec.de> <200604101015.36869.vda@ilport.com.ua> <200604100919.23244.eike-kernel@sf-tec.de> <443A2805.6000806@s5r6.in-berlin.de> In-Reply-To: <443A2805.6000806@s5r6.in-berlin.de> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Stefan Richter wrote: > Rolf Eike Beer wrote: >> Denis Vlasenko wrote: >>> I am leaving it up to maintainer to decide. After all, the driver >>> is for multiple OSes, other OS may lack mdelay(). >> The comment says about multiple milliseconds sleeps which just don't happen. > > Given what ah{c,d}_delay are (OS dependent wrappers) and how they are > used (definitely not for multi-msec delays), they should just be changed > into a #define ah{c,d}_delay(us) udelay(us) or into void inline > ah{c,d}_delay(long us) {udelay(us);}. I'd rather do a #define. Inlining simple functions is quite unneccessary here. Re multiplatform development: aic7{9,x}xx have ceased to be multiplatfrom since the integration of scsi_transport_spi. So I wouldn't worry too much about it. Cheers, Hannes -- Dr. Hannes Reinecke hare@suse.de SuSE Linux Products GmbH S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de