public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernard Pidoux <pidoux@ccr.jussieu.fr>
To: linux-kernel@vger.kernel.org
Cc: Bernard Pidoux <bpidoux@free.fr>
Subject: [kernel 2.6] Patch for mxser.c driver
Date: Tue, 11 Apr 2006 23:20:32 +0200	[thread overview]
Message-ID: <443C1DA0.1030004@ccr.jussieu.fr> (raw)

Hi,

mxser driver in kernel 2.6.16 can compile but it does not drive the 
serial multiport adapter from Moxa.

According to Moxa documentation for version 1.8, msmknod script, 
downloaded from their support site, creates ttyM0-7 and cum0-7 tty 
devices with major numbers 30 and 35 by defaults.

However, in mxser.c major device numbers are still 174 and 175.

Here is a patch to change major tty device numbers to proper default values.


--- linux/drivers/char/mxser.c.old 2006-04-11 22:35:16.000000000 +0200
+++ linux/drivers/char/mxser.c     2006-04-11 22:36:49.000000000 +0200
@@ -68,8 +68,8 @@
  #include "mxser.h"

  #define        MXSER_VERSION   "1.8"
-#define        MXSERMAJOR       174
-#define        MXSERCUMAJOR     175
+#define        MXSERMAJOR       30
+#define        MXSERCUMAJOR     35

  #define        MXSER_EVENT_TXLOW        1
  #define        MXSER_EVENT_HANGUP       2


BTW, driver source that can be downloaded from Moxa support site will 
not compile :

  make -C /lib/modules/2.6.16/build SUBDIRS=/temp/mxser1.8/driver modules
make[1]: Entering directory `/usr/src/linux-2.6.16'
   CC [M]  /temp/mxser1.8/driver/mxser.o
/temp/mxser1.8/driver/mxser.c:722: warning: initialization from 
incompatible pointer type
/temp/mxser1.8/driver/mxser.c: In function 'mxser_init':
/temp/mxser1.8/driver/mxser.c:1035: warning: assignment from 
incompatible pointer type
/temp/mxser1.8/driver/mxser.c: In function 'mxser_ioctl':
/temp/mxser1.8/driver/mxser.c:1685: warning: implicit declaration of 
function 'verify_area'
/temp/mxser1.8/driver/mxser.c: In function 'mxser_receive_chars':
/temp/mxser1.8/driver/mxser.c:2631: error: 'struct tty_ldisc' has no 
member named 'receive_room'
/temp/mxser1.8/driver/mxser.c:2638: error: 'struct tty_struct' has no 
member named 'flip'
/temp/mxser1.8/driver/mxser.c:2639: error: 'struct tty_struct' has no 
member named 'flip'
/temp/mxser1.8/driver/mxser.c:2783: error: 'struct tty_struct' has no 
member named 'flip'
/temp/mxser1.8/driver/mxser.c:2783: error: 'struct tty_struct' has no 
member named 'flip'
make[2]: *** [/temp/mxser1.8/driver/mxser.o] Erreur 1
make[1]: *** [_module_/temp/mxser1.8/driver] Erreur 2
make[1]: Leaving directory `/usr/src/linux-2.6.16'
make: *** [module] Erreur 2

If any comments please Cc: to me.

Regards from,

Bernard Pidoux, f6bvp

http://f6bvp.org
http://rose.fpac.free.fr/MINI-HOWTO/
http://rose.fpac.free.fr/MINI-HOWTO-FR/


             reply	other threads:[~2006-04-11 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-11 21:20 Bernard Pidoux [this message]
2006-04-11 22:21 ` [kernel 2.6] Patch for mxser.c driver Jiri Slaby
2006-04-12  9:36   ` Alan Cox
2006-04-24  8:50     ` Bernard Pidoux
2006-04-24 10:52       ` Jiri Slaby
2006-04-24 18:37       ` Jiri Slaby
2006-04-24 20:16         ` Alan Cox
2006-04-11 22:24 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=443C1DA0.1030004@ccr.jussieu.fr \
    --to=pidoux@ccr.jussieu.fr \
    --cc=bpidoux@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox