From: Hannes Reinecke <hare@suse.de>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
arjan@infradead.org, gibbs@scsiguy.com, eike-kernel@sf-tec.de,
stefanr@s5r6.in-berlin.de
Subject: Re: [PATCH 1/2] aic7xxx: deinline large functions, save 80k of text
Date: Wed, 12 Apr 2006 15:55:42 +0200 [thread overview]
Message-ID: <443D06DE.8060903@suse.de> (raw)
In-Reply-To: <200604120945.34419.vda@ilport.com.ua>
Denis Vlasenko wrote:
> This patch
>
> moves big inlines into aic79xx_core.c and aic7xxx_core.c
> makes ahd_delay just a wrapper around udelay
> marks a few functions static
> fixes spelling fix in error message
While you're at it; can't you move the different ah{c,d}_{in,out}.* into
one place? Have them scattered throughout the file doesn't really make
sense.
Otherwise ACK.
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
next prev parent reply other threads:[~2006-04-12 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-12 6:45 [PATCH 1/2] aic7xxx: deinline large functions, save 80k of text Denis Vlasenko
2006-04-12 6:47 ` [PATCH 2/2] aic7xxx: s/__inline/inline Denis Vlasenko
2006-04-12 13:55 ` Hannes Reinecke [this message]
2006-04-13 15:02 ` [PATCH 1/2] aic7xxx: deinline large functions, save 80k of text James Bottomley
2006-04-25 11:31 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443D06DE.8060903@suse.de \
--to=hare@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=eike-kernel@sf-tec.de \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox